Blocks: Update hpq to 1.4.0 and drop the ts-expect-error suppressions - #81199
Merged
Conversation
hpq 1.4.0 ships TypeScript declarations, so the two suppressions added in #81148 are no longer needed. Type the call sites against the new declarations.
manzoorwanijk
force-pushed
the
update/hpq-1.4.0
branch
from
August 5, 2026 05:00
71d63ee to
71e10c2
Compare
manzoorwanijk
marked this pull request as ready for review
August 5, 2026 05:00
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +43 B (0%) Total Size: 7.81 MB 📦 View Changed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Updates
hpqto 1.4.0 and drops the two@ts-expect-errorsuppressions on its imports.Follow up to #81148 (comment).
Why?
hpq1.4.0 ships TypeScript declarations, so the suppressions are no longer accurate.How?
With the imports typed, the call sites in
get-block-attributes.tsare checked for the first time and needed fixing, mostlyNodewhere hpq'sMatcherFnexpectsElement. Two casts are dropped as redundant; a non-null assertion and aMatcherObjcast are added where hpq's types are stricter than its runtime. Type-level only, no runtime changes.Testing Instructions
npm run buildsucceeds.npm run test:unit packages/blockspasses.npm run lint:jspasses.Use of AI Tools
Authored with Claude Code. I have reviewed and take responsibility for the changes.