Core Data: add missing @wordpress/base-styles dependency - #81012
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 7.76 MB |
|
Thanks for the fixes @manzoorwanijk ! |
|
@youknowriad I'm surprised to learn that I we want to move Quoting from #80485 (review)
What was the other good path? Maybe the other one was better 🙂 |
The I also don't like that I started experimenting with this idea and have a local draft, will try to polish and create a PR. |
What?
Follow up to #80485. Adds the missing
@wordpress/base-stylesdependency to@wordpress/core-data.Why?
#80485 moved
entities-saved-states/style.scssintocore-data, which uses@wordpress/base-styles, but the dependency was never declared in the package'spackage.json. See #80485 (comment).The missing dependency was caught in #75814, which uses isolated dependencies.
How?
Declares
@wordpress/base-stylesindependencies, matching how other style-shipping packages (block-editor,editor,components) declare it.Testing Instructions
npm installandnpm run build.packages/core-data/src/components/entities-saved-states/style.scsscompiles.Use of AI Tools
Authored with the help of Claude Code, reviewed by the PR author.