Storybook: Remove Emotion as JSX import source - #80647
Merged
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 7.75 MB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Updates Storybook configuration to remove the
jsxImportSourceoverride to@emotion/react.Follow-up to #80426 and specifically #80426 (comment).
Why?
jsxImportSourcecauses the import source to be injected into packages that don't necessarily define the dependency themselves, which will break under isolated npm install being explored in Explore using npm install-strategy=linked #75814.@emotion/reactJSX import source is primarily necessary to supportcssprop assignment to components, but the last instance of this was removed in Components: migrate View away from Emotion #79443.How?
Removes the explicit
jsxImportSourceoverride in the Storybook configuration so that it falls back to the default (react).@emotion/reactstill needs to be a dependency instorybook/package.jsonbecause it is a peer dependency of@emotion/styled, which is still used in the@wordpress/storybooktool package.Testing Instructions
Repeating Testing Instructions from #79443.
It's also worth testing that the live Storybook (via both
npm run storybook:devandnpm run storybook:buildbuild output) is unaffected, since this configuration is common to all Storybook builds:npm run storybook:build && cd storybook/build && php -S localhost:8000Use of AI Tools
Used Cursor IDE + Auto (likely Composer) model to explore the initial proposal at #80426 (comment) and understand the viability of removing the override. Manually reviewed.