Skip to content

Storybook: fix Emotion jsxImportSource #80426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simison merged 4 commits into from
Jul 17, 2026
Merged

Storybook: fix Emotion jsxImportSource #80426

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0a9cfa2
Storybook: pre-bundle CJS deps
simison Jul 17, 2026
ce68cc1
Storybook: Preserve Emotion module identity
ciampo Jul 17, 2026
fdd3040
Storybook: Test the development server
ciampo Jul 17, 2026
4ea310a
Storybook: Remove development server smoke test
ciampo Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion storybook/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ const config: StorybookConfig = {
plugins: [
dsTokenFallbacksJs(),
react( {
jsxImportSource: getAbsolutePath( '@emotion/react' ),
jsxImportSource: '@emotion/react',

@manzoorwanijk manzoorwanijk Jul 20, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change, we will need to set an alias for this; otherwise, it will break the isolated build.

diff --git a/storybook/main.ts b/storybook/main.ts
index 36358c13df1..fd266c7de2c 100644
--- a/storybook/main.ts
+++ b/storybook/main.ts
@@ -224,6 +224,16 @@ const config: StorybookConfig = {
 				),
 			},
 			resolve: {
+				alias: {
+					/*
+					 * `jsxImportSource` injects `@emotion/react` into every JSX
+					 * file, including stories in packages that don't depend on
+					 * it (e.g. block-editor) and can't resolve it under the
+					 * isolated dependency layout. Alias it to this workspace's
+					 * copy — the one all consumers already resolve to.
+					 */
+					'@emotion/react': getAbsolutePath( '@emotion/react' ),
+				},
 				/*
 				 * Resolve Storybook packages from this workspace.
 				 */

@aduth aduth Jul 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better yet: We can remove this altogether? 🙂 #80647

babel: {
plugins: [ getAbsolutePath( '@emotion/babel-plugin' ) ],
},
Expand Down
Loading