UI: improve component code readability in Storybook by using arrays for children - #80352
Conversation
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
1 similar comment
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 7.72 MB |
|
Flaky tests detected in 6770226. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/29492196268
|
ciampo
left a comment
There was a problem hiding this comment.
🧹 🚀
Looks like a clean migration, let's try it out!
|
Given how prone to conflicts this PR is, I'll go ahead and merge |
|
Should we work on a small lint rule to encourage array notation over fragments in Storybook: |
|
Another thing I was curious about but didn't have a chance to look is whether we actually need |
Good question. Something to investigate and potentially iterate on. In general, I prefer tedious but correct / compliant code. |
|
We could maybe use |
Follow-up to #77382 (comment)
Alternative to #80129
Pairs with #80132 which adds
displayNames.What?
Avoid
<React.Fragment>appearing in code examples by using[]instead of<>in Storybook examples.Cleaner code previews and copy-paste for docs consumers.
How?
Testing Instructions
Run
npm run storybook:devSmoke test different stories and code snippets.
Testing Instructions for Keyboard
Screenshots or screencast
Before
After
Use of AI Tools
yes