Skip to content

Image: Use Playwright's locator.drop for media placeholder drop test #79733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mamaduka merged 1 commit into from
Jul 1, 2026
Merged

Image: Use Playwright's locator.drop for media placeholder drop test #79733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions test/e2e/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
"@types/node": "^20.19.39",
"@wordpress/e2e-test-utils-playwright": "file:../../packages/e2e-test-utils-playwright",
"@wordpress/scripts": "file:../../packages/scripts",
"@wordpress/vips": "file:../../packages/vips",
"@y/websocket-server": "^0.1.1",
"esbuild": "^0.27.2",
"filenamify": "^4.2.0",
Expand Down
28 changes: 2 additions & 26 deletions test/e2e/specs/editor/blocks/image.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,6 @@ test.describe( 'Image', () => {

test( 'should drag and drop files into media placeholder', async ( {
editor,
page,
imageBlockUtils,
} ) => {
await editor.insertBlock( { name: 'core/image' } );
Expand All @@ -208,33 +207,10 @@ test.describe( 'Image', () => {
name: 'This image has an empty alt attribute',
} );

const tmpInput = await page.evaluateHandle( () => {
const input = document.createElement( 'input' );
input.type = 'file';
return input;
await imageBlock.drop( {
files: [ imageBlockUtils.TEST_IMAGE_FILE_PATH ],
} );

await imageBlockUtils.upload( tmpInput );

const paragraphRect = await imageBlock.boundingBox();
const pX = paragraphRect.x + paragraphRect.width / 2;
const pY = paragraphRect.y + paragraphRect.height / 3;

await imageBlock.evaluate(
( element, [ input, clientX, clientY ] ) => {
const dataTransfer = new window.DataTransfer();
dataTransfer.items.add( input.files[ 0 ] );
const event = new window.DragEvent( 'drop', {
bubbles: true,
clientX,
clientY,
dataTransfer,
} );
element.dispatchEvent( event );
},
[ tmpInput, pX, pY ]
);

// Wait for upload to complete (includes client-side media processing time).
await expect( image ).toHaveAttribute( 'src', /^https?:\/\//, {
timeout: 30_000,
Expand Down
Loading