Skip to content

Declare undeclared workspace dependencies #79684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manzoorwanijk merged 2 commits into from
Jun 30, 2026
Merged

Declare undeclared workspace dependencies #79684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0924c75
Declare undeclared workspace dependencies
manzoorwanijk Jun 30, 2026
95f5a3d
@wordpress/ui: Add changelog entry for overlay focus helper return type
manzoorwanijk Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 26 additions & 5 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion packages/admin-ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,10 @@
"clsx": "^2.1.1"
},
"devDependencies": {
"@storybook/react-vite": "^10.4.3",
"@testing-library/dom": "^10.4.1",
"@testing-library/react": "^16.3.2"
"@testing-library/react": "^16.3.2",
"@wordpress/icons": "file:../icons"
},
"peerDependencies": {
"@types/react": "^18.3.27",
Expand Down
1 change: 1 addition & 0 deletions packages/block-editor/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@
"@testing-library/react": "^16.3.2",
"@testing-library/user-event": "^14.6.1",
"@types/postcss-prefix-selector": "^1.16.3",
"@wordpress/block-library": "file:../block-library",
"deep-freeze": "^0.0.1"
},
"peerDependencies": {
Expand Down
1 change: 1 addition & 0 deletions packages/block-library/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@
},
"devDependencies": {
"@testing-library/dom": "^10.4.1",
"@testing-library/jest-dom": "^6.9.1",
"@testing-library/react": "^16.3.2",
"@testing-library/user-event": "^14.6.1",
"@wordpress/stylelint-tools": "file:../../tools/stylelint",
Expand Down
3 changes: 3 additions & 0 deletions packages/e2e-tests/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@
"@wordpress/interactivity": "file:../interactivity",
"@wordpress/interactivity-router": "file:../interactivity-router"
},
"devDependencies": {
"y-websocket": "^3.0.0"
},
"peerDependencies": {
"jest": ">=29",
"puppeteer-core": ">=23",
Expand Down
1 change: 0 additions & 1 deletion packages/e2e-tests/plugins/rtc-websocket-provider/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
* window.__gutenbergTestWebSocketSync.rooms that the Playwright fixtures poll.
*/

// eslint-disable-next-line import/no-extraneous-dependencies -- declared in test/e2e/package.json, only loaded by the WS e2e harness.
import { WebsocketProvider } from 'y-websocket';

const TEST_PROVIDER_NAMESPACE = 'gutenberg-test/rtc-websocket-provider';
Expand Down
1 change: 1 addition & 0 deletions packages/editor/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@
"uuid": "^14.0.0"
},
"devDependencies": {
"@storybook/react-vite": "^10.4.3",
"@testing-library/dom": "^10.4.1",
"@testing-library/react": "^16.3.2",
"@testing-library/user-event": "^14.6.1",
Expand Down
1 change: 1 addition & 0 deletions packages/media-editor/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@
"gl-matrix": "^3.4.3"
},
"devDependencies": {
"@storybook/react-vite": "^10.4.3",
"@testing-library/dom": "^10.4.1",
"@testing-library/react": "^16.3.2",
"@testing-library/user-event": "^14.6.1"
Expand Down
4 changes: 3 additions & 1 deletion packages/readable-js-assets-webpack-plugin/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,9 @@
"devDependencies": {
"glob": "^7.1.2",
"mkdirp": "^3.0.1",
"terser-webpack-plugin": "^5.3.10"
"rimraf": "^5.0.10",
"terser-webpack-plugin": "^5.3.10",
"webpack": "^5.108.1"
},
"peerDependencies": {
"webpack": "^4.8.3 || ^5.0.0"
Expand Down
3 changes: 3 additions & 0 deletions packages/redux-routine/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@
"is-promise": "^4.0.0",
"rungen": "^0.3.2"
},
"devDependencies": {
"redux": "^5.0.1"
},
"peerDependencies": {
"redux": ">=4"
},
Expand Down
1 change: 1 addition & 0 deletions packages/report-flaky-tests/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
"@jest/test-result": "^29.6.2",
"@octokit/types": "^6.34.0",
"@octokit/webhooks-types": "^5.8.0",
"@playwright/test": "^1.58.2",
"jest-message-util": "^29.6.2"
},
"devDependencies": {
Expand Down
3 changes: 3 additions & 0 deletions packages/server-side-render/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,9 @@
"@wordpress/i18n": "file:../i18n",
"@wordpress/url": "file:../url"
},
"devDependencies": {
"@types/jest": "^29.5.14"
},
"peerDependencies": {
"@types/react": "^18.3.27",
"react": "^18.0.0",
Expand Down
1 change: 1 addition & 0 deletions packages/ui/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

### Internal

- Add an explicit return type to an internal overlay focus helper so the published type definitions stay self-contained ([#79684](https://github.com/WordPress/gutenberg/pull/79684)).
- Add a temporary `@wordpress/theme` `ThemeProvider` compatibility fallback for older WordPress runtimes ([#79620](https://github.com/WordPress/gutenberg/pull/79620)).
- Enforce CSS Module class selector naming for component-library packages ([#79504](https://github.com/WordPress/gutenberg/pull/79504)).
- Update `@base-ui/react` from `1.5.0` to [`1.6.0`](https://github.com/mui/base-ui/releases/tag/v1.6.0) ([#79408](https://github.com/WordPress/gutenberg/pull/79408)).
Expand Down
1 change: 1 addition & 0 deletions packages/ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@
"@testing-library/user-event": "^14.6.1",
"@types/jest": "^29.5.14",
"@types/node": "^20.19.39",
"fast-glob": "^3.2.7",
"storybook": "^10.4.3"
},
"peerDependencies": {
Expand Down
7 changes: 6 additions & 1 deletion packages/ui/src/utils/use-deprioritized-initial-focus.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@ import { tabbable } from 'tabbable';
*/
type InitialFocus = _Popover.Popup.Props[ 'initialFocus' ];

type DeprioritizedInitialFocus = {
resolvedInitialFocus: InitialFocus;
popupRef: React.RefObject< HTMLDivElement >;
};

/**
* Options matching Base UI's internal tabbable configuration.
* @see https://github.com/floating-ui/floating-ui/blob/master/packages/react/src/utils/tabbable.ts
Expand Down Expand Up @@ -49,7 +54,7 @@ export function useDeprioritizedInitialFocus( {
}: {
initialFocus: InitialFocus;
deprioritizedAttributes: string[];
} ) {
} ): DeprioritizedInitialFocus {
const popupRef = useRef< HTMLDivElement >( null );

// Returning a fresh callback on every render is intentional. Base UI
Expand Down
1 change: 1 addition & 0 deletions routes/connectors-home/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
"@wordpress/a11y": "file:../../packages/a11y",
"@wordpress/admin-ui": "file:../../packages/admin-ui",
"@wordpress/api-fetch": "file:../../packages/api-fetch",
"@wordpress/base-styles": "file:../../packages/base-styles",
"@wordpress/components": "file:../../packages/components",
"@wordpress/connectors": "file:../../packages/connectors",
"@wordpress/core-data": "file:../../packages/core-data",
Expand Down
1 change: 1 addition & 0 deletions test/unit/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
"@wordpress/scripts": "file:../../packages/scripts",
"babel-jest": "^29.7.0",
"babel-plugin-transform-import-meta": "^2.3.3",
"client-zip": "^2.4.5",

@aduth aduth Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mock is a little strange. I suppose this is what we achieve elsewhere with transformIgnorePatterns in managing ESM-only packages. I'm a bit surprised by this behavior, as I would have thought we could just rely on require(esm) in tests, but I guess not with our current Jest setup. That sounds like a problem we'll continue to run into more often as packages increasingly go ESM-only.

@manzoorwanijk manzoorwanijk Jun 30, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it needs some changes to Jest config I think.

@aduth aduth Jun 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit surprised by this behavior, as I would have thought we could just rely on require(esm) in tests, but I guess not with our current Jest setup.

It looks like this was added pretty recently to Jest, though oddly only for Node.js 24.9+:

Main feature is a rewrite of our custom runtime in preparation for stabilisation of native support of ESM. As part of that work require(esm) module is now supported on Node 24.9+ (still requires --experimental-vm-modules like before).

https://github.com/jestjs/jest/releases/tag/v30.4.0

I suppose we can count that as covered by #72593.

"glob": "^7.1.2",
"jest": "^29.6.2",
"jest-environment-jsdom": "^30.2.0",
Expand Down
1 change: 1 addition & 0 deletions tools/docs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
"devDependencies": {
"@apidevtools/json-schema-ref-parser": "^11.6.4",
"@babel/core": "^7.25.7",
"@wordpress/docgen": "file:../../packages/docgen",
"chalk": "^4.1.1",
"change-case": "^4.1.2",
"comment-parser": "^1.1.1",
Expand Down
2 changes: 2 additions & 0 deletions tools/stylelint/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@
"./config": "./config.js"
},
"dependencies": {
"@wordpress/stylelint-config": "file:../../packages/stylelint-config",
"@wordpress/theme": "file:../../packages/theme",
"stylelint-plugin-logical-css": "^1.2.3"
},
"publishConfig": {
Expand Down
Loading