-
Notifications
You must be signed in to change notification settings - Fork 4.9k
design-system-mcp: Include component status notes in details response #78475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aduth
wants to merge
2
commits into
update/storybook-component-status-central
Choose a base branch
from
update/component-manifest-status-notes
base: update/storybook-component-status-central
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| /** | ||
| * Storybook preset that merges `notes` from the component-status registry | ||
| * onto each entry in the components manifest. | ||
| */ | ||
| import type { ComponentManifest, Manifests } from 'storybook/internal/types'; | ||
| import { COMPONENT_STATUS } from '../component-status'; | ||
|
|
||
| type ComponentManifestWithNotes = ComponentManifest & { notes?: string }; | ||
|
|
||
| const REGISTRY = COMPONENT_STATUS as Record< | ||
| string, | ||
| Record< string, { notes?: string } > | ||
| >; | ||
|
|
||
| /** | ||
| * Derive the npm package name from a manifest entry's story file path. | ||
| * | ||
| * @param storyPath - The story file path recorded on the manifest entry. | ||
| * @return The npm package name, or `null` for paths outside `packages/*`. | ||
| */ | ||
| function packageNameFromPath( storyPath: string ): string | null { | ||
| const match = storyPath.match( /\.\.\/packages\/([^/]+)\// ); | ||
| return match ? `@wordpress/${ match[ 1 ] }` : null; | ||
| } | ||
|
|
||
| /** | ||
| * Reduce a namespace component name (e.g. `AlertDialog.Root`) to the | ||
| * top-level importable identifier used as the registry key. | ||
| * | ||
| * @param name - The component name from the manifest. | ||
| * @return The top-level importable identifier. | ||
| */ | ||
| function canonicalComponentName( name: string ): string { | ||
| return name.split( '.', 1 )[ 0 ]; | ||
| } | ||
|
|
||
| // Disable reason: This is the name that Storybook expects to use for overriding | ||
| // experimental manifests behavior. | ||
| // eslint-disable-next-line camelcase | ||
| export const experimental_manifests = async ( | ||
| existing: Manifests | undefined | ||
| ): Promise< Manifests > => { | ||
| const components = existing?.components; | ||
| if ( ! components ) { | ||
| return existing ?? {}; | ||
| } | ||
|
|
||
| const next: Record< string, ComponentManifestWithNotes > = {}; | ||
| for ( const [ id, entry ] of Object.entries( components.components ) ) { | ||
| const packageName = packageNameFromPath( entry.path ); | ||
| const componentName = canonicalComponentName( entry.name ); | ||
| const status = packageName | ||
| ? REGISTRY[ packageName ]?.[ componentName ] | ||
| : undefined; | ||
|
|
||
| next[ id ] = status?.notes ? { ...entry, notes: status.notes } : entry; | ||
| } | ||
|
|
||
| return { | ||
| ...existing, | ||
| components: { ...components, components: next }, | ||
| }; | ||
| }; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This only includes the notes rather than the full status object. That should be okay based on what we're doing now because the manifest already only contains
status: 'recommended'+whereUsed: 'global'components, but I've mentioned before that it could be useful for the MCP server to surface some of our "use-with-caution" components depending on the situation. So maybe it'd be more future-proof to pass through the whole object, or at leaststatus+notes. Then again, it could be perfectly fine to addstatusas a sibling property, rather than maintain thecomponentStatusobject wrapper.