Skip to content

Build Tools: Scope wp-build's deregister-before-register to @wordpress/* modules #77465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
retrofox wants to merge 2 commits into from
Closed

Build Tools: Scope wp-build's deregister-before-register to @wordpress/* modules #77465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4cc5bc0
wp-build: scope deregister to @wordpress/* only
retrofox Apr 17, 2026
a110704
Merge branch 'trunk' into fix/wp-build-scope-deregister
retrofox Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/wp-build/templates/module-registration.php.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,12 @@ function {{PREFIX}}_register_script_modules() {
$asset = file_exists( $asset_path ) ? require $asset_path : array();

// Deregister first to override any previously registered version
// (e.g., Core's default modules when running as a plugin).
wp_deregister_script_module( $module['id'] );
// of Core's default script modules. Scoped to `@wordpress/*` — the
// only namespace Core registers by default — so plugin-local and
// shared packages preserve Core's idempotent "first-wins" semantics.
if ( str_starts_with( $module['id'], '@wordpress/' ) ) {
wp_deregister_script_module( $module['id'] );
}

wp_register_script_module(
$module['id'],
Expand Down
14 changes: 10 additions & 4 deletions packages/wp-build/templates/routes-registration.php.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,11 @@ function {{PREFIX}}_register_page_routes( $page_routes, $register_function_name
$content_handle = '{{HANDLE_PREFIX}}/routes/' . $route['name'] . '/content';
$extension = defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG ? '.js' : '.min.js';
// Deregister first to override any previously registered version
// (e.g., Core's default modules when running as a plugin).
wp_deregister_script_module( $content_handle );
// of Core's default script modules. Scoped to `@wordpress/*` — the
// only namespace Core registers by default.
if ( str_starts_with( $content_handle, '@wordpress/' ) ) {
wp_deregister_script_module( $content_handle );
}
wp_register_script_module(
$content_handle,
$build_constants['build_url'] . 'routes/' . $route['name'] . '/content' . $extension,
Expand All @@ -73,8 +76,11 @@ function {{PREFIX}}_register_page_routes( $page_routes, $register_function_name
$route_handle = '{{HANDLE_PREFIX}}/routes/' . $route['name'] . '/route';
$extension = defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG ? '.js' : '.min.js';
// Deregister first to override any previously registered version
// (e.g., Core's default modules when running as a plugin).
wp_deregister_script_module( $route_handle );
// of Core's default script modules. Scoped to `@wordpress/*` — the
// only namespace Core registers by default.
if ( str_starts_with( $route_handle, '@wordpress/' ) ) {
wp_deregister_script_module( $route_handle );
}
wp_register_script_module(
$route_handle,
$build_constants['build_url'] . 'routes/' . $route['name'] . '/route' . $extension,
Expand Down
Loading