Skip to content

Fix script module dequeue race condition #76170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowriad merged 2 commits into from
Mar 18, 2026
+10 −0
Merged

Fix script module dequeue race condition #76170

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d08e97
Fix script module dequeue race condition
adamsilverstein Mar 5, 2026
983f504
restore from trunk
adamsilverstein Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/wp-build/templates/module-registration.php.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,16 @@
* Register all script modules.
*/
function {{PREFIX}}_register_script_modules() {
// Ensure this only runs once. wp_default_scripts can fire multiple times,
// and each wp_deregister_script_module() call also dequeues the module.
// If a module was enqueued between calls, repeated deregister/register
// cycles would lose the enqueue state.
static $already_registered = false;
if ( $already_registered ) {
return;
}
$already_registered = true;

// Load build constants
$build_constants = require __DIR__ . '/constants.php';
$modules_dir = __DIR__ . '/modules';
Expand Down
Loading