Skip to content

Fixed - Improved accessibility and keyboard usability for request logs provider/model details in the WordPress admin #889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
murshed wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Fixed - Improved accessibility and keyboard usability for request logs provider/model details in the WordPress admin #889

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
25ed517
Improved Accessibility and UI behavior
Jul 21, 2026
08268d6
Merge branch 'WordPress:develop' into develop
murshed Jul 21, 2026
becb985
Merge branch 'develop' into develop
jeffpaul Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions src/admin/ai-request-logs/components/LogsTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import {
} from '@wordpress/dataviews';
import { dateI18n, getSettings } from '@wordpress/date';
import { __, sprintf } from '@wordpress/i18n';
import { useCallback, useMemo, useState } from '@wordpress/element';
import { useCallback, useMemo, useRef, useState } from '@wordpress/element';
import { rotateRight } from '@wordpress/icons';

/**
Expand Down Expand Up @@ -293,6 +293,9 @@ const ProviderCell: React.FC< ProviderCellProps > = ( {
connectorsUrl,
} ) => {
const [ isPopoverVisible, setIsPopoverVisible ] = useState( false );
const popoverId = useRef(
`ai-request-logs-provider-popover-${ Math.random().toString( 36 ).slice( 2 ) }`
);

if ( ! provider && ! model ) {
return <span className="ai-request-logs__cell-muted">-</span>;
Expand All @@ -317,14 +320,20 @@ const ProviderCell: React.FC< ProviderCellProps > = ( {

return (
<div
className="ai-request-logs__provider-cell"
className="ai-request-logs__provider-cell ai-request-logs__provider-trigger"
role="button"
tabIndex={ 0 }
onClick={ () => setIsPopoverVisible( ( prev ) => ! prev ) }
aria-haspopup="dialog"
aria-expanded={ isPopoverVisible }
aria-controls={ popoverId.current }
onKeyDown={ ( e ) => {
if ( 'Enter' === e.key || ' ' === e.key ) {
e.preventDefault();
setIsPopoverVisible( ( prev ) => ! prev );
} else if ( 'Escape' === e.key && isPopoverVisible ) {
e.preventDefault();
setIsPopoverVisible( false );
}
} }
>
Expand All @@ -347,7 +356,10 @@ const ProviderCell: React.FC< ProviderCellProps > = ( {
className="ai-request-logs__provider-popover"
onClose={ () => setIsPopoverVisible( false ) }
>
<div className="ai-request-logs__popover-content">
<div
id={ popoverId.current }
className="ai-request-logs__popover-content"
>
<div className="ai-request-logs__popover-header">
<span className="ai-request-logs__popover-icon">
{ renderProviderLogo( metadata ) }
Expand Down
13 changes: 13 additions & 0 deletions src/admin/ai-request-logs/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,19 @@
.ai-request-logs__provider-cell {
position: relative;
cursor: pointer;
width: 100%;
border: 0;
background: transparent;
padding: 0;
text-align: left;
color: inherit;
font: inherit;
}

.ai-request-logs__provider-trigger:focus-visible {
outline: 2px solid #2271b1;
outline-offset: 2px;
border-radius: 4px;
}

.ai-request-logs__provider-row {
Expand Down
Loading