SEC-140: Generate unified Ethereum client configuration - #36
Draft
huangminghuang wants to merge 4 commits into
Draft
SEC-140: Generate unified Ethereum client configuration#36huangminghuang wants to merge 4 commits into
huangminghuang wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data/ethereum-client.jsonfor local clusters and pass it through--outpost-ethereum-client-config-fileto every batch-operator and underwriter daemonschema_version, nestedconnection, and a numericchain_ideth-default; each daemon registers its own Ethereum key under that name without sharing private keys across processestransaction_policyfrom generated development-cluster files so nodeop applies the schema defaults and preserves pre-policy behaviormaster, preserving its key-source, debugger, labeling, and external-outpost behavior while adopting the new client schemaGenerated configuration
{ "schema_version": 1, "clients": [ { "connection": { "client_id": "eth-default", "signature_provider_id": "eth-default", "rpc_url": "http://127.0.0.1:<anvil-port>" }, "chain_id": 31337 } ] }The omitted
transaction_policyintentionally selects nodeop's default policy. Production policy selection remains outsidewire-tools-ts.Design alignment
The earlier implementation followed the draft flat JSON shape (
version, flat connection fields, and a string chain id). Wire-Network/wire-sysio#531 now defines the host-side configuration withclient_config.proto; this PR emits and validates that exact structure for both local and external outposts.Validation
@wireio/cluster-toolsuite: 115 suites, 802 tests passedpnpm lintpnpm --filter @wireio/cluster-tool build(validated against published@wireio/sdk-core@1.0.78; the local sibling checkout is behind the current SDK API)git diff --check270f03e2: defaultallbuild completed (765 targets), the 39-test Ethereum client/plugin suite passed, andnodeop --helpexposes--outpost-ethereum-client-config-fileA local combined
flow-swap-with-underwritingattempt stopped during the initial system-contract bootstrap with an unrelated native/system-contract ABI decode error insysio::onblockandsysio::setpriv, before Ethereum artifacts or operator daemons were prepared. It therefore did not exercise this PR's configuration path and is not presented as a successful end-to-end result.Dependency
Requires Wire-Network/wire-sysio#531 at head
270f03e2(or a descendant containing its protobuf client-config loader and--outpost-ethereum-client-config-file).Jira: SEC-140