Skip to content

[spec] Test subsumption in return call result types#2211

Open
CharlieTap wants to merge 3 commits into
WebAssembly:mainfrom
CharlieTap:return-call-result-subtyping
Open

[spec] Test subsumption in return call result types#2211
CharlieTap wants to merge 3 commits into
WebAssembly:mainfrom
CharlieTap:return-call-result-subtyping

Conversation

@CharlieTap

@CharlieTap CharlieTap commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

While validating a GC module in my runtime, I found that return_call and return_call_indirect were comparing result types for exact equality instead of using result type matching. This was a left over from implementing tail call before gc, and caused a certain valid fixture to fail.

This PR adds tests for both instructions. For each instruction, I've included a valid case showing that (ref array) matches (ref eq), and an invalid case showing that the reverse direction is rejected. The cases are intentionally minimal rather than repeating the broader subsumption coverage already present.

@rossberg rossberg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread test/core/gc/type-subtyping.wast Outdated
Comment thread test/core/gc/type-subtyping.wast Outdated

@rossberg rossberg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the churn, but on second thought, these tests belong in the respective test files for return_call and return_call_indirect (and return_call_ref, for that matter). The subtyping.wast file is meant to test the correctness of the subtyping algorithm itself (for GC types), not whether it is applied in all the right places.

Since the respective test files are not under gc/, though, it would be good to avoid the use of GC types, e.g., use (ref $functype) vs funcref instead, which should work independent of the presence of GC.

@CharlieTap

Copy link
Copy Markdown
Contributor Author

No worries thats actually a nicer solution 👍🏼

@rossberg rossberg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you also add a respective test for return_call_ref?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants