-
Notifications
You must be signed in to change notification settings - Fork 530
[spec] Add call_addr and throw_addr as admin instructions #2189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rossberg
wants to merge
7
commits into
main
Choose a base branch
from
call_addr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a9e0f5e
[spec] Make call_addr and throw_addr into admin instructions
rossberg fd8bce0
Fix typing rules
rossberg 17afb46
Fix throw_ref rule
rossberg 130563f
Fix throw_addr to signal unhandled exception
f52985 e580051
Adjust spec doc
rossberg b3a31da
Merge branch 'main' into call_addr
rossberg dd1c61a
Tweak doc
rossberg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,20 +11,6 @@ rule Instr_ok2/plain: | |
| s; C |- instr : t_1* ->_(x*) t_2* | ||
| -- Instr_ok: C |- instr : t_1* ->_(x*) t_2* | ||
|
|
||
| rule Instr_ok2/call_ref: | ||
| s; C |- CALL_REF yy : t_1* (REF NULL yy) -> t_2* | ||
| -- Typeuse_ok: C |- yy : OK | ||
| -- Expand_use: yy ~~_C FUNC t_1* -> t_2* | ||
|
|
||
| ;; TODO(3, rossberg): enable t_2* <: C.RETURN | ||
| rule Instr_ok2/return_call_ref: | ||
| s; C |- RETURN_CALL_REF yy : t_3* t_1* (REF NULL yy) -> t_4* | ||
| -- Typeuse_ok: C |- yy : OK | ||
| -- Expand_use: yy ~~_C FUNC t_1* -> t_2* | ||
| -- if C.RETURN = (t'_2*) | ||
| -- Resulttype_sub: C |- t_2* <: t'_2* | ||
| -- Instrtype_ok: C |- t_3* -> t_4* : OK | ||
|
|
||
| rule Instr_ok2/ref: | ||
| s; C |- ref : eps -> rt | ||
| -- Ref_ok: s |- ref : rt | ||
|
|
@@ -45,6 +31,25 @@ rule Instr_ok2/handler: | |
| -- (Catch_ok: C |- catch : OK)* | ||
| -- Instrs_ok2: s; C |- instr* : eps ->_(x*) t* | ||
|
|
||
| rule Instr_ok2/call_addr: | ||
| s; C |- CALL_ADDR a : t_1* (REF NULL dt) -> t_2* | ||
| -- if s.FUNCS[a].TYPE = dt | ||
| -- Expand: dt ~~ FUNC t_1* -> t_2* | ||
|
|
||
| ;; TODO(3, rossberg): enable t_2* <: C.RETURN | ||
| rule Instr_ok2/return_call_addr: | ||
| s; C |- RETURN_CALL_ADDR a : t_3* t_1* (REF NULL dt) -> t_4* | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same for the |
||
| -- if s.FUNCS[a].TYPE = dt | ||
| -- Expand: dt ~~ FUNC t_1* -> t_2* | ||
| -- if C.RETURN = (t'_2*) | ||
| -- Resulttype_sub: C |- t_2* <: t'_2* | ||
| -- Instrtype_ok: C |- t_3* -> t_4* : OK | ||
|
|
||
| rule Instr_ok2/throw_addr: | ||
| s; C |- THROW_ADDR a : t_1* t* -> t_2* | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. t^* here looks to be droppable as well (same as the above 2) |
||
| -- Expand_use: s.TAGS[s.EXNS[a].TAG].TYPE ~~_C FUNC t* -> eps | ||
| -- Instrtype_ok: C |- t_1* -> t_2* : OK | ||
|
|
||
| rule Instr_ok2/trap: | ||
| s; C |- TRAP : t_1* -> t_2* | ||
| -- Instrtype_ok: C |- t_1* -> t_2* : OK | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I thought we would be able to drop the additional REF NULL dt here given that call_addr is now the dedicated invoke admin instruction (so it only resolves the lookup and invoke the function frame).