Don't strip away Consul metadata if we return a single value#92
Closed
nickpegg wants to merge 1 commit into
Closed
Don't strip away Consul metadata if we return a single value#92nickpegg wants to merge 1 commit into
nickpegg wants to merge 1 commit into
Conversation
Fixes an inconsistency outlined in #39 where a KV `get` call returns an array if >1 value is returned, but if one value is returned it strips away the metadata and hands back the raw value. While this is a friendly thing to do in some cases, it creates a very annoying inconsistency when doing a recursive `get` which leaves out the metadata (most importantly the key of the returned value) as well as requiring the consumer to check whether the return value of `get` is a String or Array.
|
👍 we need this bad. we'll have to run a fork in the meantime |
Contributor
|
dupe of #51 AFAICS but i guess it is nonsense creating pull requests here anyway |
Contributor
Author
|
Closing in favor for #51 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an inconsistency outlined in #39 where a KV
getcall returns an array if >1 value is returned, but if one value is returned it
strips away the metadata and hands back the raw value.
While this is a friendly thing to do in some cases, it creates a very annoying
inconsistency when doing a recursive
getwhich leaves out the metadata(most importantly the key of the returned value) as well as requiring the
consumer to check whether the return value of
getis a String or Array.