add option to search all nodes and services filtering by metadata#161
add option to search all nodes and services filtering by metadata#161rockpapergoat wants to merge 4 commits into
Conversation
|
well, this is disappointing. i thought this worked. the query url gets constructed correctly, but it looks like faraday eats the nested query parameters. i'm not sure how to get faraday to accept these params but am looking. so the url gets constructed like so: but then the consul log shows just the last node-meta param:
|
pierresouchay
left a comment
pierresouchay
left a comment
There was a problem hiding this comment.
This looks great, than you for the PR
|
lgtm |
|
@rockpapergoat Did you succeeded into faraday accepting multiple filters? |
|
i got diverted from this at work for a bit and haven't revisited it, but i believe it's still an issue. the changes i made most likely won't work as expected until sorting out the faraday portion. |
|
looks like this will do it. i'll try to test this sometime soon. https://github.com/lostisland/faraday#changing-how-parameters-are-serialized |
|
yeah, that option works. i'll add something to docs to show how to use it. |
|
Great! Send the patch, we'll merge it |
searching for multiple metadata fields should work for nodes. i'm not sure if it works for services yet, even though it looks like it should. i don't think this requires any changes to docs, as i rolled the faraday requests option in if metadata is passed.
|
i updated the code. tests fail for a few ruby versions, though it looks like some of them are linting issues. do we need to fix those first? tests pass on ruby 2.5.1 here for me. |
|
@rockpapergoat rebase and I'll merge it |
|
@rockpapergoat Can you rebase this PR? Thanks) |
4 participants
These small changes add options to the node and service
get_allmethods to allow including metadata filters in the URL passed to the consul API. I updated the spec tests and docs to reflect this change, but let me know if you need anything else here. Thanks!