{vm,vl,vt}cluster: fixed volume names while using useLegacyNaming#2386
Draft
AndrewChubatiuk wants to merge 1 commit into
Draft
{vm,vl,vt}cluster: fixed volume names while using useLegacyNaming#2386AndrewChubatiuk wants to merge 1 commit into
AndrewChubatiuk wants to merge 1 commit into
Conversation
AndrewChubatiuk
force-pushed
the
fix-legacy-naming-for-volumes
branch
from
July 8, 2026 16:07
1da8990 to
820e05d
Compare
vrutkovs
reviewed
Jul 13, 2026
vrutkovs
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, we should note the breaking change in API
| @@ -13,6 +13,8 @@ aliases: | |||
|
|
|||
| ## tip | |||
|
|
|||
Collaborator
There was a problem hiding this comment.
Suggested change
| ### API breaking change | |
| `GetStorageVolumeName` / `GetCacheMountVolumeName` moved from component types to cluster types |
AndrewChubatiuk
marked this pull request as draft
July 17, 2026 19:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2385