refactor(builder): Run generateVersionInfo by default#1453
refactor(builder): Run generateVersionInfo by default#1453maxreichmann wants to merge 8 commits into
generateVersionInfo by default#1453Conversation
`+` Fix some related tests
generateVersionInfo
`+` Adjust Standard Tasks table (TODO: check `transformBootstrapHTML` link!!)
generateVersionInfogenerateVersionInfo by default
|
We should also check how this now relates to the |
`+` docs: Replace hardcoded URLs (ui5.github.io/..) with dynamic links `+` docs: Add links to all Builder tasks in Standard Tasks table `+` refactor: Remove "jsdoc" npm script (+remove unused dep `open-cli`)
130029c to
0d3d9db
Compare
8125892 to
f354410
Compare
(versionInfo middleware still runs -> sap-ui-version.json is generated) `+` add test verifying exclusion `+` adjust docs stating this exclusion
f354410 to
b6ca355
Compare
|
Update:
"Side tasks done": I'm also fine to move those changes out to another PR if this eases the review process. |
matz3
left a comment
There was a problem hiding this comment.
"Side tasks done": I'm also fine to move those changes out to another PR if this eases the review process.
Yes, I think that would help with reviewing the docs changes. Thanks for looking into that!
| | [generateBundle](../api/module-@ui5_builder_tasks_bundlers_generateBundle) | *disabled* <sup>4</sup> | *disabled* <sup>4</sup> | *disabled* <sup>4</sup> | | | ||
| | [buildThemes](../api/module-@ui5_builder_tasks_buildThemes) | | | enabled | enabled | | ||
| | [generateThemeDesignerResources](../api/module-@ui5_builder_tasks_generateThemeDesignerResources) | | | *disabled* <sup>5</sup> | *disabled* <sup>5</sup> | | ||
| | [generateVersionInfo](../api/module-@ui5_builder_tasks_generateVersionInfo) | enabled | *disabled* | *disabled* | *disabled* | |
There was a problem hiding this comment.
If I see the diff correctly, the *disabled* for the types other than application have been added. Previously, the cells were empty, which means the task can never be executed for that project type (based on the build definition, like packages/project/lib/build/definitions/application.js), even if explicitly enabled by the caller.
I do not see code changes that change this situation, and I think the previous state still holds true: During a build, we only support running the generateVersionInfo for application projects, and it can not be enabled for other project types.
| | [generateBundle](../api/module-@ui5_builder_tasks_bundlers_generateBundle) | *disabled* <sup>4</sup> | *disabled* <sup>4</sup> | *disabled* <sup>4</sup> | | | ||
| | [buildThemes](../api/module-@ui5_builder_tasks_buildThemes) | | | enabled | enabled | | ||
| | [generateThemeDesignerResources](../api/module-@ui5_builder_tasks_generateThemeDesignerResources) | | | *disabled* <sup>5</sup> | *disabled* <sup>5</sup> | | ||
| | [generateVersionInfo](../api/module-@ui5_builder_tasks_generateVersionInfo) | enabled | *disabled* | *disabled* | *disabled* | |
There was a problem hiding this comment.
Should we add a foot-note for the server exception also here? This page is in context of the builder, but as we also run a build on the dev server, I think it would be worth noting here as well.
| ui5DataDir, | ||
| }) { | ||
| // Explicitly exclude task "generateVersionInfo" for Server builds | ||
| // because middleware "versionInfo" will generate the version info anyways. |
There was a problem hiding this comment.
This handling should be moved to into the @ui5/server code in packages/server/lib/server.js, which does provide an HTTP server with the mentioned versionInfo middleware.
This @ui5/project API only returns the BuildServer, which is the underlying functionality, but it is not opinionated about the integration, and does not know about the versionInfo middleware.
This means that the BuildServer integration tests are likely unaffected by this change, which is fine.
JIRA: CPOUI5FOUNDATION-1157
What has been done?
generateVersionInforemovedapplication(default, jsdoc, self-contained)generateVersionInfomigrate-v5.md: new section explaining new behaviorBuilder.md: changedgenerateVersionInfofrom disabled to enabled in Standard Tasks tableInfo
generateVersionInfois explicitly NOT executed because middlewareversionInfoIS executed (which createssap-ui-version.jsonanyways)generateVersionInfo: BuildServer.integration.js:1030sap-ui-version.jsonis generated: server/test/lib/server/main.js:204Side tasks done
jsdoc(deprecated & not used in CI)open-cli