Conversation
Add taxonomy terms to right sidebar on oda_pages node/add
There was a problem hiding this comment.
Pull request overview
Adds editorial UI grouping so the “report access” taxonomy field appears under an Advanced details group when creating/editing ODA “data page” nodes, aligning it with the existing data report node form behavior.
Changes:
- Add an “Access” details group on
node_oda_page_*node forms under the Advanced vertical tab. - Assign
field_oda_report_accessto the new details group for better form organization.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+244
to
+248
| $form['oda_access_group'] = [ | ||
| '#title' => t('Data Report Access Group'), | ||
| '#type' => 'details', | ||
| '#group' => 'advanced', | ||
| '#open' => 1, |
Contributor
There was a problem hiding this comment.
Addressed in b268e12. I extracted the duplicated oda_access_group details array into _oda_access_group_details() and reused it in both form-id branches to keep them in sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe context / purpose for this PR
Add data permissions to data pages
Issue link
https://github.com/UCBoulder/oit_dingo/issues/1321
Any other related PRs?
Link to MultiDev instance
http://md-1321-ucbsub-oit.pantheonsite.io
Checklist for PR author