Skip to content

ATDT-528: Throw RetriableException for all 500 class errors #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
quang-do-se merged 2 commits into from
Mar 16, 2026
Merged

ATDT-528: Throw RetriableException for all 500 class errors #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc72120
ATDT-528: Throw RetriableException for all 500 class errors
ahmanwoods Oct 15, 2025
0ff1ee4
ATDT-528: Update test
ahmanwoods Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/main/java/edu/ksu/canvas/net/SimpleRestClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,9 +351,9 @@ private void checkHeaders(ClassicHttpResponse httpResponse, HttpUriRequestBase r
LOG.error("Object not found in Canvas. Requested URL: " + uri);
throw new ObjectNotFoundException(extractErrorMessageFromResponse(httpResponse), String.valueOf(uri));
}
if(statusCode == 504) {
LOG.error("504 Gateway Time-out while requesting: " + uri);
throw new RetriableException("status code: 504, reason phrase: Gateway Time-out", String.valueOf(uri));
if(statusCode >= 500 && statusCode < 600) {
LOG.error("Error " + statusCode + " while requesting: " + uri);
throw new RetriableException("500 class error with status code: " + statusCode, String.valueOf(uri));
}
// If we receive a 5xx exception, we should not wrap it in an unchecked exception for upstream clients to deal with.
if(statusCode < 200 || (statusCode > (allowRedirect?399:299) && statusCode <= 499)) {
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/edu/ksu/canvas/net/SimpleRestClientUTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ void http503ServiceTemporarilyUnavailableException() throws Exception {
String url = "/unavailableServiceUrl";
registerUrlResponse(url, "", 503, Collections.emptyMap());

assertThrows(IOException.class, () -> {
assertThrows(RetriableException.class, () -> {
final Response response = restClient.sendApiGet(emptyAdminToken, baseUrl + url, 100, 100);
});
}
Expand Down