feat(types): notification outcome and grouping fields - #41
Merged
Conversation
The API returns `outcome`, `groupKey` and `groupLabel` on every automation notification and this mirror does not have them, so an app building against the published package is told they do not exist. `outcome` is the one that matters. Without it the only way to know whether a run failed is to match on `title`, and `title` is built from the user's own automation name — an automation called "Failover sync" reports every successful run as a failure to anything reading the copy. That is not hypothetical; it shipped in our own client and had to be fixed there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API returns
outcome,groupKeyandgroupLabelon every automation notification andNotificationDtodoes not have them, so an app building against the published package is told they do not exist.Changes
outcome,groupKeyandgroupLabelonNotificationDto, matching the backend's wire DTO.outcomeis the one that matters. Without it the only way to know whether a run failed is to match ontitle, andtitleis built from the user's own automation name, so an automation called "Failover sync" reports every successful run as a failure to anything reading the copy. That shipped in our own client and had to be fixed there.Types only, one changeset, patch.