Refactor personalized links

[samuelwei]

Name is no longer required, allow personalized links where guests can enter their own name if not enforced

Fixes #

Type

• Bugfix
• Feature
• Documentation
• Refactoring (e.g. Style updates, Test implementation, etc.)
• Other (please describe):

Checklist

• Code updated to current develop branch head
• Passes CI checks
• Is a part of an issue
• Tests added for the bugfix or newly implemented feature, describe below why if not
• Changelog is updated
• Documentation of code and features exists

Changes

Screenshots

List of links

Options for each link

Usage of link with enforced name

Usage of link without enforced name

User is asked for name on first load

User can still change the name later

Other information

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7eb54d7d-a98f-4cd9-90a0-ba832345b111

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

❌ Patch coverage is 4.76190% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.92%. Comparing base (3a3f95c) to head (c7e8126).

Files with missing lines	Patch %	Lines
...s/components/RoomTabPersonalizedLinksAddButton.vue	0.00%	10 Missing ⚠️
.../components/RoomTabPersonalizedLinksEditButton.vue	16.66%	5 Missing ⚠️
...sources/js/components/RoomTabPersonalizedLinks.vue	0.00%	2 Missing ⚠️
.../components/RoomTabPersonalizedLinksCopyButton.vue	0.00%	1 Missing ⚠️
...omponents/RoomTabPersonalizedLinksDeleteButton.vue	0.00%	1 Missing ⚠️
resources/js/views/RoomsView.vue	0.00%	1 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##             develop    #3388      +/-   ##
=============================================
- Coverage      97.02%   90.92%   -6.11%     
=============================================
  Files            490      201     -289     
  Lines          16996    10166    -6830     
  Branches        2485     2487       +2     
=============================================
- Hits           16491     9243    -7248     
- Misses           505      923     +418     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[cypress]

PILOS    Run #3261

Run Properties:   Failed #3261  •  c7e8126593: Refactor personalized links

Project	PILOS
Branch Review	3387-refactor-personalized-room-links
Run status	Failed #3261
Run duration	09m 20s
Commit	c7e8126593: Refactor personalized links
Committer	Samuel Weirich
View all properties for this run ↗︎

---

Test results
Failures	12
Flaky	0
Pending	0
Skipped	0
Passing	643
View all changes introduced in this branch ↗︎

---

Tests for review

  e2e/RoomsJoinWithLobby.cy.js • 1 failed test • System tests

View Output

Test		Artifacts
Room Join with lobby settings > Lobby enabled for guests only		Test Replay Screenshots

  tests/Frontend/e2e/RoomsViewPersonalizedLinksTokenActions.cy.js • 6 failed tests • Frontend tests

View Output

Test		Artifacts
Rooms view personalized links actions > add new personalized link		Test Replay Screenshots
Rooms view personalized links actions > add new personalized link errors		Test Replay Screenshots
Rooms view personalized links actions > edit personalized link		Test Replay Screenshots
Rooms view personalized links actions > edit personalized link errors		Test Replay Screenshots
Rooms view personalized links actions > delete personalized link		Test Replay Screenshots
Rooms view personalized links actions > copy personalized link		Test Replay Screenshots

  tests/Frontend/e2e/RoomsViewPersonalizedLinks.cy.js • 5 failed tests • Frontend tests

View Output

Test		Artifacts
Rooms view personalized links > load personalized links		Test Replay Screenshots
Rooms view personalized links > load personalized links errors		Test Replay Screenshots
Rooms view personalized links > search personalized links		Test Replay Screenshots
Rooms view personalized links > filter personalized links		Test Replay Screenshots
Rooms view personalized links > sort personalized links		Test Replay Screenshots