added the GEMSpinner::produceStringForValue() feature - #139
Open
clarencelocke wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #138:
Currently the
printMenuItems()method will always explicitly generate a string representation of aGEMSpinnerValueviaitoa()ordtostrf().I have a situation where the underlying spinner value happens to be a byte (the underlying source is an
enumvalue), but there exists a human-readable string representation of those values (e.g., 1 = "Apple", 2 = "Bear", 3 = "Cat", etc.). When the menu item is printed (and also when it is being edited), it would be much more useful to display the human readable string instead of the string representation of the byte value.I had proposed an API in the above open issue — this PR is my attempt at implementing that enhancement. I believe that I have address the changes in all of the correct locations (but my actual use case is targeting the U8G2 code base so I did not test the Adafruit case).