Let get_streams work from the path alone on Neuralynx, Biocam and Blackrock - #4727
Open
h-mayorquin wants to merge 2 commits into
Open
Let get_streams work from the path alone on Neuralynx, Biocam and Blackrock#4727h-mayorquin wants to merge 2 commits into
get_streams work from the path alone on Neuralynx, Biocam and Blackrock#4727h-mayorquin wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When adding
exclude_filenametoNeuralynxSortingExtractor(the recording extractor already had it and both go through the sameNeuralynxRawIO) I realized thatget_neo_streams("neuralynx", folder_path)throws aTypeError. The extra arguments inmap_to_neo_kwargshave no defaults so the call fails on our own signature before neo is reached. Biocam is the same and blackrock never passedgap_tolerance_msthrough there at all.I added the defaults that the constructors already pass. All these errors have the same shape so I think it is good to add a general check instead of a test for the three formats that I found. I am adding it to
RecordingCommonTestSuiteto avoid this problem in the future.