Skip to content

added a state to hold the current text being typed #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timea-solid merged 4 commits into from
Jul 24, 2026
Merged

added a state to hold the current text being typed #845

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0c9770d
added a state to hold the current text being typed
timea-solid Jul 24, 2026
52a7e15
chore: update solidos dependencies (dev: solid-logic@4.0.8-1 pane-reg…
github-actions[bot] Jul 24, 2026
c4dd284
Potential fix for pull request finding
timea-solid Jul 24, 2026
c1551a4
Fix RDFInput local value clearing after save
Copilot Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 10 additions & 2 deletions src/components/rdf-input/RDFInput.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { property } from 'lit/decorators.js'
import { property, state } from 'lit/decorators.js'
import { html } from 'lit/html.js'
import ns from '../../lib/ns'
import { customElement, generateId, WebComponent } from '@/lib/components'
Expand Down Expand Up @@ -32,6 +32,9 @@ export default class RDFInput extends WebComponent {
@property({ type: Number })
accessor storeVersion = 0

@state()
private accessor localInputValue: string | null = null

private _updateInFlight = false
private _pendingUpdateValue: string | null = null

Expand Down Expand Up @@ -59,7 +62,9 @@ export default class RDFInput extends WebComponent {
// for populating the HTML input element
const selectedTerm = this.getSelectedTerm(this.dataSubject, uiPropertyTerm, this.formSubject, params)
const placeholder = readonly ? '' : this.defaultInputValue(params)
const inputValue = this.termToInputValue(selectedTerm)
const inputValue = this.localInputValue !== null || this._updateInFlight
? this.localInputValue ?? ''
: this.termToInputValue(selectedTerm)
Comment thread
Copilot marked this conversation as resolved.
Outdated

return html`
<solid-ui-input
Expand Down Expand Up @@ -131,6 +136,7 @@ export default class RDFInput extends WebComponent {

private async updateData (e: CustomEvent) {
const newValue = (e.target as HTMLInputElement).value
this.localInputValue = newValue
this._pendingUpdateValue = newValue

if (this._updateInFlight) {
Expand All @@ -152,6 +158,7 @@ export default class RDFInput extends WebComponent {
const uiPropertyTerm = this.getFormProperty(this.formSubject, ns.ui('property'), this.getDocument(this.formSubject))
if (!uiPropertyTerm || !this.dataSubject) {
this._updateInFlight = false
this.localInputValue = ''
return
}

Expand Down Expand Up @@ -193,6 +200,7 @@ export default class RDFInput extends WebComponent {
try {
await this.storeContext.store.updater.updateMany(toDeleteSt, toInsertSt as any)
this.storeVersion += 1
this.localInputValue = ''
} catch (err) {
console.error('RDFInput update failed', err)
} finally {
Expand Down
Loading