Conversation
fix dev login to match new authn
…@3.1.3-4) (latest: rdflib@2.3.9)
…er-pane into solidosDependencies
Solidos dependencies
…@3.1.3-9) (latest: rdflib@2.4.0)
…@3.1.3-11) (latest: rdflib@2.4.0)
…-pane into feat/migrate-vite
…@3.1.3-11) (latest: rdflib@2.4.0)
Migrate to Vite #225
…@3.1.3-13) (latest: rdflib@2.4.0)
…@3.1.3-14) (latest: rdflib@2.4.0)
Fix the problem with uploading files with the plus
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the build/dev tooling from the previous Webpack-based setup to a Vite + solidos-toolkit-based setup, updates packaging to emit artifacts under dist/, and tweaks the folder pane UI to expand the file-drop target area.
Changes:
- Replace Webpack configs and dev harness with a Vite config (
vite.config.mts) and Vite-based build scripts/output (dist/). - Update package publishing metadata (
main/types/exports) and CI to includestagingand run a reusable dependency-update workflow. - Improve the upload drop-zone UX by applying the drop target to a larger container and adding corresponding CSS.
Reviewed changes
Copilot reviewed 14 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| webpack.module.rules.mjs | Removed Webpack loader rules as part of migrating away from Webpack. |
| webpack.dev.config.mjs | Removed Webpack dev-server configuration. |
| webpack.config.mjs | Removed Webpack production build configuration. |
| vite.config.mts | Added Vite configuration using solidos-toolkit build/pane plugins. |
| tsconfig.json | Updated TS build output folder and module resolution for bundler workflows. |
| src/styles/folderPane.css | Added styling for a larger drag-and-drop zone. |
| src/index.ts | Added new entry point re-exporting the pane for Vite library build. |
| src/folderPane.ts | Changed drop target element to expand the effective drop zone. |
| package.json | Updated build scripts, outputs/exports, deps, and branch push behavior for staging. |
| dev/index.js | Removed the Webpack-based local dev harness. |
| dev/index.html | Removed the Webpack-based dev HTML entry. |
| dev/dev-global.css | Removed dev-only global CSS used by the old harness. |
| dev/context.js | Removed dev harness context adapter. |
| babel.config.mjs | Removed Babel config previously used by Webpack pipeline. |
| .gitignore | Switched ignored build output from lib/ to dist/. |
| .github/workflows/ci.yml | Added staging triggers and a reusable update-deps prerequisite job; adjusted publish job permissions. |
Suppressed comments (1)
package.json:35
package.json#filesincludesLICENSE, but the repository hasLICENSE.md(so the license file won’t be included in the published package).
"files": [
"dist/",
"declarations.d.ts",
"README.md",
"LICENSE"
],
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
24
to
+28
| "test": "echo \"No tests specified\" && exit 0", | ||
| "prepublishOnly": "npm run build && npm run lint", | ||
| "preversion": "npm run typecheck && npm run lint", | ||
| "postpublish": "git push origin main --follow-tags", | ||
| "start": "webpack serve --config webpack.dev.config.mjs --open" | ||
| "postpublish": "git push origin staging", | ||
| "start": "vite" |
Comment on lines
+71
to
+75
| "solid-logic": "4.0.8-2", | ||
| "solid-ui": "3.1.3-14", | ||
| "vite": "^8.0.16", | ||
| "vitest": "^4.0.18", | ||
| "vitest-axe": "^0.1.0" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.