feat: Show list of ignored gems - #2354
Open
written-fresh wants to merge 1 commit into
Open
Conversation
written-fresh
force-pushed
the
feat/show-skipped-gems
branch
from
August 4, 2026 22:21
1ee1e56 to
6645633
Compare
written-fresh
marked this pull request as ready for review
August 4, 2026 22:24
KaanOzkan
reviewed
Aug 5, 2026
written-fresh
force-pushed
the
feat/show-skipped-gems
branch
from
August 5, 2026 15:22
51a7713 to
28d3674
Compare
written-fresh
force-pushed
the
feat/show-skipped-gems
branch
from
August 5, 2026 15:25
28d3674 to
bcc671b
Compare
KaanOzkan
reviewed
Aug 18, 2026
KaanOzkan
left a comment
KaanOzkan
left a comment
Contributor
There was a problem hiding this comment.
Thank you, few more refactors. Also there might be some long lines, it'd be good to run rubocop before pushing.
Comment on lines
+20
to
+22
| gem_queue = gems_to_generate(@gem_names) | ||
| user_excluded_gems = user_excluded_gem_names(gem_queue) | ||
| gem_queue.reject! { |gem| @exclude.include?(gem.name) } |
Contributor
There was a problem hiding this comment.
Suggested change
| gem_queue = gems_to_generate(@gem_names) | |
| user_excluded_gems = user_excluded_gem_names(gem_queue) | |
| gem_queue.reject! { |gem| @exclude.include?(gem.name) } | |
| user_excluded_gems = @gem_names & @exclude | |
| gem_queue = gems_to_generate(@gem_names) | |
| gem_queue.reject! { |gem| @exclude.include?(gem.name) } |
Simpler
Contributor
There was a problem hiding this comment.
Also I think we should move user_excluded_gems assignment right before it's printed. It's nicer I believe.
| def gems_to_generate(gem_names) | ||
| return @bundle.dependencies if gem_names.empty? | ||
|
|
||
| (gem_names - @exclude).each_with_object([]) do |gem_name, gems| |
Contributor
There was a problem hiding this comment.
Suggested change
| gem_names.each_with_object([]) do |gem_name, gems| |
Comment on lines
+84
to
+89
| def user_excluded_gem_names(gem_queue) | ||
| @exclude.uniq.select do |gem_name| | ||
| @bundle.gem(gem_name) && | ||
| (@gem_names.include?(gem_name) || gem_queue.any? { |gem| gem.name == gem_name }) | ||
| end | ||
| end |
Contributor
There was a problem hiding this comment.
Suggested change
| def user_excluded_gem_names(gem_queue) | |
| @exclude.uniq.select do |gem_name| | |
| @bundle.gem(gem_name) && | |
| (@gem_names.include?(gem_name) || gem_queue.any? { |gem| gem.name == gem_name }) | |
| end | |
| end |
| @@ -44,6 +46,14 @@ | |||
| else | |||
| say("No operations performed, all RBIs are up-to-date.", [:green, :bold]) | |||
Contributor
There was a problem hiding this comment.
This should be printed at the end, let's move the new prints before this if/else.
| say("No operations performed, all RBIs are up-to-date.", [:green, :bold]) | ||
| end | ||
| unless @skipped_gems.empty? | ||
| say("\nNote: Tapioca is skipping gem rbi generation for following gems due to the built-in configuration:", [:yellow, :bold]) |
Contributor
There was a problem hiding this comment.
Suggested change
| say("\nNote: Tapioca is skipping gem rbi generation for following gems due to the built-in configuration:", [:yellow, :bold]) | |
| say("\nNote: Tapioca skipped RBI generation for the following gems because they are ignored by default:", [:yellow, :bold]) |
| say(@skipped_gems.join(", "), [:yellow, :bold]) | ||
| end | ||
| unless user_excluded_gems.empty? | ||
| say("\nNote: Tapioca is skipping gem rbi generation for following gems due to user configuration:", [:yellow, :bold]) |
Contributor
There was a problem hiding this comment.
Suggested change
| say("\nNote: Tapioca is skipping gem rbi generation for following gems due to user configuration:", [:yellow, :bold]) | |
| say("\nNote: Tapioca skipped RBI generation for the following gems because they were excluded:", [:yellow, :bold]) |
| assert_success_status(result) | ||
| end | ||
|
|
||
| it "reports explicitly requested ignored gems" do |
Contributor
There was a problem hiding this comment.
Can you also add a test for not reporting excluded gems when we only run gem and gem --all?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR addresses #1347 which aims to show a message when trying to run
tapioca gemon a ignored gem.Implementation
I have added a skipped gems property to the cli.
Tests
I have now written a test just to confirm something like
gem sorbetoutputs the warning that it was skipped. More than happy to add more if needed.No warning
Warning