-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
[rb] generate the BiDi protocol layer from the shared binding-neutral schema #17731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 15 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
836894c
[rb] generate the BiDi protocol layer from the shared binding-neutralβ¦
titusfortner 45c6cd3
[rb] simplify BiDi value construction and move Union combination valiβ¦
titusfortner c155ac0
[rb] reject a non-nullable field set to nil at construction
titusfortner 64e9f1a
[rb] parse nested RemoteValues inside object/map results
titusfortner 2fdaa9c
[rb] rename Serialization::Data to Serialization::Record to avoid ::Dβ¦
titusfortner d5372e8
[rb] add Protocol::Domain base so generated classes share the transpoβ¦
titusfortner 88ef296
[rb] split BiDi generated-layer specs into serialization and protocol
titusfortner 4f665d3
[rb] resolve the BiDi transport from a driver or bridge, with integraβ¦
titusfortner d02dbbc
[rb] allow BiDi domains to be constructed with either Transport or Drβ¦
titusfortner e1b8746
[rb] accept BiDi enum values as symbols, round-tripping symbol-in/symβ¦
titusfortner 570cdb4
[rb] make BiDi inbound enum and variant parsing strict, raising on unβ¦
titusfortner 2adb4f7
[rb] correct stale serialization comments after strict inbound parsing
titusfortner 1afbccd
[rb] validate inbound nullability and list shape, expose BiDi socket β¦
titusfortner dfe3025
[rb] add a test that checked-in BiDi protocol code matches the generaβ¦
titusfortner 89680d0
[rb] reject a scalar for a list-typed BiDi field, and fix review nitsβ¦
titusfortner ef75736
[rb] resolve the verify test schema via rootpath so it is runfiles-saβ¦
titusfortner a062f1c
[rb] validate scalar BiDi enums without coercing enumerables, and reqβ¦
titusfortner 3c6de1c
[rb] enforce required-presence when parsing inbound BiDi responses
titusfortner 5cd24d0
[rb] rename the BiDi Record field wire key from json_key to wire_key
titusfortner 9c63005
[rb] reject omitting a required field when constructing outbound BiDiβ¦
titusfortner e1381c2
[rb] separate optional keyword from nilable value in generated BiDi RBS
titusfortner 1625afb
[rb] reject a scalar where an object is expected when parsing inboundβ¦
titusfortner 48d5b03
[rb] validate inbound scalar primitive types when parsing BiDi records
titusfortner 10f8088
[rb] type baked BiDi discriminators to their const in generated RBS
titusfortner 45fe5c5
[rb] fix "user prompts" grammar in BiDi browsing context spec
titusfortner 6812d9b
[rb] require an Integer for integer-typed inbound BiDi fields
titusfortner 505d33b
[rb] drop dead unknown-primitive handling from the BiDi generator
titusfortner fc6f2db
[rb] make the BiDi verify-test schema lookup path-separator agnostic
titusfortner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| # Licensed to the Software Freedom Conservancy (SFC) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The SFC licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| # serialization must load first (it defines the Serialization runtime the generated | ||
| # classes build on), then the Domain base the generated classes subclass. Add a require | ||
| # below when a new BiDi domain is generated. | ||
| require 'selenium/webdriver/bidi/serialization' | ||
| require 'selenium/webdriver/bidi/transport' | ||
| require 'selenium/webdriver/bidi/protocol/domain' | ||
| require 'selenium/webdriver/bidi/protocol/bluetooth' | ||
| require 'selenium/webdriver/bidi/protocol/browser' | ||
| require 'selenium/webdriver/bidi/protocol/browsing_context' | ||
| require 'selenium/webdriver/bidi/protocol/emulation' | ||
| require 'selenium/webdriver/bidi/protocol/input' | ||
| require 'selenium/webdriver/bidi/protocol/log' | ||
| require 'selenium/webdriver/bidi/protocol/network' | ||
| require 'selenium/webdriver/bidi/protocol/permissions' | ||
| require 'selenium/webdriver/bidi/protocol/script' | ||
| require 'selenium/webdriver/bidi/protocol/session' | ||
| require 'selenium/webdriver/bidi/protocol/speculation' | ||
| require 'selenium/webdriver/bidi/protocol/storage' | ||
| require 'selenium/webdriver/bidi/protocol/user_agent_client_hints' | ||
| require 'selenium/webdriver/bidi/protocol/web_extension' |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.