fix(settlement): verify on-chain broadcast confirmation before marking claims settled - #8234
Open
trexfr-ops wants to merge 1 commit into
Open
Conversation
Contributor
|
Welcome to RustChain! Thanks for your first pull request. Before we review, please make sure:
Bounty tiers: Micro (1-10 RTC) | Standard (20-50) | Major (75-100) | Critical (100-150) A maintainer will review your PR soon. Thanks for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #8230
This PR addresses the false-success pathways in
sign_and_broadcast_transaction()where claims could transition to settled with a synthetic hash when no broadcast to the network occurred.Changes
TREASURY_KEY_PATHandNODE_API_URLconfiguration; returns(False, None, error_message)if unset./api/tx/submitbefore returningsuccess=Trueandon_chain_hash.success=Falsewith error details, allowingprocess_claims_batch()to release pool funds and retain claims for retry.TestSignAndBroadcastTransactionsuite covering missing configuration, signing errors, broadcast failures, and verified 2xx success (100% pass).Bounty Payout Addresses
0x32BB3df5B74a594956a0f33Bc353511Fa759FCa48Xo39uq9LoaM2rQEkgaaSfuThqHZTd18yGdJSXffkLwMLPnftYop8yhRNQZstysT3vuJf3XkpQWKTCbc1qpyu6866qcgt26sqw4dn2mlmp8d0yc657fuedkvDDMU6D9TCE3BhqqYyy7MUZQD7JhfL39FpE