feat: add cosmetics support to per-message profiles#369
Closed
poolcritter wants to merge 1 commit into
Closed
Conversation
This patch allows the following keys to be set on messages' `com.beeper.per_message_profiles` key: * `moe.sable.app.name_color`: Overrides the name color; same format as `moe.sable.app.name_color` in profiles. * `io.fsky.nyx.pronouns`: Overrides the per-message pronouns; same format as `io.fsky.nyx.pronouns` in profiles. # Considerations * The ability to override custom fonts has intentionally been left unimplemented. Per-message fonts could allow users to specify custom name fonts without needing room-admin approval, which could be dangerous.
Member
|
is that related/an alternative to #309? |
dozro
reviewed
Mar 18, 2026
|
|
||
| const sourcePronouns = pmp?.["io.fsky.nyx.pronouns"] ?? profile.pronouns ?? [] | ||
| const mergedPronouns = useMemo(() => { | ||
| const existing = profile.pronouns ? [...profile.pronouns] : []; |
Member
There was a problem hiding this comment.
#309 already handles per-message-profile's pronouns iirc
Author
There was a problem hiding this comment.
oh yeah, didn't notice — should I rebase onto there?
dozro
requested changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch allows the following keys to be set on messages'
com.beeper.per_message_profileskey:moe.sable.app.name_color: Overrides the name color; same format asmoe.sable.app.name_colorin profiles.io.fsky.nyx.pronouns: Overrides the per-message pronouns; same format asio.fsky.nyx.pronounsin profiles.Considerations