tests: remove legacy intg test suite - #9078
Draft
danlavu wants to merge 5 commits into
Draft
Conversation
danlavu
marked this pull request as draft
August 13, 2026 19:17
Port sssd/src/tests/intg/test_pam_responder.py to test_smartcard.py, test_authentication.py - test_smartcard__login_fails_when_wrong_pin_is_entered - test_smartcard__login_fails_when_card_is_not_mapped - test_smartcard__cert_auth_limited_to_allowed_pam_services - test_smartcard__login_succeeds_when_cert_auth_required - test_smartcard__login_fails_when_cert_auth_required_without_card - test_authentication__custom_password_prompt_is_shown_at_login Peeling out the reviewed test cases into it's own PR, from SSSD#8873 AI: Claude Sonnet 4.6 Co-authored-by: Cursor <cursoragent@cursor.com>
Remove test cases from src/tests/intg/test_pam_responder.py that have been ported to src/tests/system/tests/test_smartcard.py. AI: Claude Sonnet 4.6 Co-authored-by: Cursor <cursoragent@cursor.com>
Replace inline expect script in test_smartcard__unlock_console_with_vlock with client.auth.su.vlock_smartcard(), moving the logic into the test framework. Co-authored-by: Cursor <cursoragent@cursor.com>
danlavu
force-pushed
the
remove-intg-tests
branch
from
August 14, 2026 15:40
842758b to
4546d2a
Compare
Rewrite the remaining sssd/src/tests/intg/test_pam_responder.py cases to test_smartcard.py, test_authentication.py - test_try_sc_auth_root -> test_smartcard__try_cert_auth_never_used_for_root - test_sc_auth_missing_name, test_sc_auth_missing_name_whitespace -> test_smartcard__certificate_owner_resolved_when_username_is_missing - test_sc_auth_name_format -> test_smartcard__certificate_owner_resolved_with_full_name_format - test_sc_auth_two_missing_name -> test_smartcard__certificate_owner_resolved_with_two_tokens_and_missing_name - test_krb5_auth_domains -> test_authentication__pam_sss_domains_skips_non_matching_krb5_domains Authenticate once per realm with that realm's password and assert the TGT realm matches, covering the pam_sss domains try-and-error path. Peeling out the reviewed test cases into it's own PR, from SSSD#8873 AI: Cursor Grok 4.5 Co-authored-by: Cursor <cursoragent@cursor.com>
Remove src/tests/intg and all associated build infrastructure now that the relevant tests have been ported to src/tests/system. - Delete src/tests/intg/ and src/external/intgcheck.m4 - Remove intgcheck job from .github/workflows/ci.yml - Remove intgcheck targets from Makefile.am - Remove intgcheck m4_include and Makefile output from configure.ac - Remove intgcheck entry from contrib/ci/get-matrix.py - Remove intgcheck logic from contrib/ci/run and contrib/ci/deps.sh AI: Claude Sonnet 4.6 Co-authored-by: Cursor <cursoragent@cursor.com>
danlavu
force-pushed
the
remove-intg-tests
branch
from
August 14, 2026 16:09
4546d2a to
7d942b8
Compare
alexey-tikhonov
self-requested a review
August 17, 2026 18:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove src/tests/intg and all associated build infrastructure now that
the relevant tests have been ported to src/tests/system.
Depends on
AI: Claude Sonnet 4.6
Co-authored-by: Cursor cursoragent@cursor.com