Warn when a tool is defined in multiple configuration files - #110
Open
ZayanKhan-12 wants to merge 1 commit into
Open
Warn when a tool is defined in multiple configuration files#110ZayanKhan-12 wants to merge 1 commit into
ZayanKhan-12 wants to merge 1 commit into
Conversation
Foreman aggregates foreman.toml files from the current directory up to the filesystem root plus the user configuration, with the first definition of a tool taking precedence. When two files define the same tool alias differently, the override was completely silent and easy to miss. Log a warning naming the alias, the definition being used and the one being ignored. Identical duplicate definitions stay silent. Precedence is unchanged, covered by a new test. Closes Roblox#63 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #63
Foreman aggregates
foreman.tomlfiles from the current directory up to the filesystem root, plus the user configuration, with the first definition of a tool alias taking precedence (ConfigFile::fill_from). When two files define the same alias differently, the override was completely silent — exactly the footgun described in #63.fill_fromnow logs a warning naming the alias, the definition in effect, and the one being ignored:Design notes:
duplicate_tool_definitions_keep_the_first_one).Verification
cargo test --locked: all suites pass (48 tests, including the new one)cargo fmt -- --checkclean;cargo clippyintroduces no new warnings🤖 Generated with Claude Code