Skip to content

refactor(memory-parser): collapse duplicated operand formatting #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wescopeland merged 2 commits into from
Jun 22, 2026
Merged

refactor(memory-parser): collapse duplicated operand formatting #56

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e0b519
refactor(memory-parser): collapse duplicated operand formatting
wescopeland Jun 22, 2026
603208a
fix: address feedback
wescopeland Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .cursor/rules/use-bun-instead-of-node-vite-npm-pnpm.mdc
View file
Open in desktop

This file was deleted.

186 changes: 186 additions & 0 deletions src/utils/memory-parser.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1170,4 +1170,190 @@ describe("Util: memory-parser", () => {
expect(result.groups[2]).toHaveLength(1);
});
});

// Characterization snapshots that pin the asymmetric edge-case behavior
// baked into the three parse paths. If any of these break, the refactor
// changed observable behavior.
describe("parseMemory characterization", () => {
const cases: Array<[string, ParsedRequirement]> = [
[
"f-100=0",
{
flag: "",
lType: "f",
lSize: "",
lMemory: "-100",
cmp: "=",
rType: "",
rSize: "",
rMemVal: "0",
hits: "0",
},
],
[
"0xH1234=f-100",
{
flag: "",
lType: "",
lSize: "0xh",
lMemory: "1234",
cmp: "=",
rType: "f",
rSize: "",
rMemVal: "-100",
hits: "0",
},
],
[
"0xH1234-5",
{
flag: "",
lType: "m",
lSize: "0xh",
lMemory: "0x1234-5",
cmp: "=",
rType: "v",
rSize: "",
rMemVal: "",
hits: "0",
},
],
[
"K:{recall}==5",
{
flag: "k",
lType: "recall",
lSize: "",
lMemory: "",
cmp: "==",
rType: "v",
rSize: "",
rMemVal: "0x000005",
hits: "",
},
],
[
"K:{recall}+false",
{
flag: "k",
lType: "recall",
lSize: "",
lMemory: "",
cmp: "+",
rType: "v",
rSize: "",
rMemVal: "false",
hits: "",
},
],
[
"H1234=5",
{
flag: "",
lType: "v",
lSize: "",
lMemory: "0x001234",
cmp: "=",
rType: "v",
rSize: "",
rMemVal: "0x000005",
hits: "0",
},
],
[
"I:0xG0045ba18+{recall}",
{
flag: "i",
lType: "m",
lSize: "0xg",
lMemory: "0x0045ba18",
cmp: "+",
rType: "recall",
rSize: "",
rMemVal: "",
hits: "0",
},
],
[
"K:{varname}+2",
{
flag: "k",
lType: "variable",
lSize: "",
lMemory: "varname",
cmp: "+",
rType: "v",
rSize: "",
rMemVal: "0x000002",
hits: "",
},
],
[
"K:{recall}+-100",
{
flag: "k",
lType: "recall",
lSize: "",
lMemory: "",
cmp: "+",
rType: "v",
rSize: "",
rMemVal: "0x000-64",
hits: "",
},
],
[
"I:-100+{recall}",
{
flag: "i",
lType: "v",
lSize: "",
lMemory: "0x000-64",
cmp: "+",
rType: "recall",
rSize: "",
rMemVal: "",
hits: "0",
},
],
[
"K:{varname}+-100",
{
flag: "k",
lType: "variable",
lSize: "",
lMemory: "varname",
cmp: "+",
rType: "v",
rSize: "",
rMemVal: "0x000-64",
hits: "",
},
],
[
"A:{varname}",
{
flag: "a",
lType: "variable",
lSize: "",
lMemory: "varname",
cmp: "",
rType: "",
rSize: "",
rMemVal: "",
hits: "0",
},
],
];

for (const [input, expected] of cases) {
it(`pins ${input}`, () => {
// ACT
const result = parseMemory(input);

// ASSERT
expect(result.groups[0]?.[0]).toEqual(expected);
});
}
});
});
Loading
Loading