[release/internal/3.8.x] Remove git version suffix - #957
Draft
ethanwee1 wants to merge 1 commit into
Draft
Conversation
Build TRITON_VERSION from the base version plus only the externally supplied TRITON_WHEEL_VERSION_SUFFIX, instead of also appending the git commit hash via get_triton_version_suffix(). When a consumer (e.g. PyTorch's build_triton_wheel.py) checks out a pinned commit as a detached HEAD, get_git_version_suffix() adds a "+git<sha>" segment. Combined with the supplied TRITON_WHEEL_VERSION_SUFFIX (e.g. "+rocm<ver>.git<sha>", whose "+" is then rewritten to "-"), the wheel is versioned "3.8.0+git<sha>.rocm<ver>.git<sha>". That no longer matches the "triton==3.8.0+rocm<ver>.git<sha>" dependency pinned into the torch wheel, so `pip install torch` fails to resolve triton. Mirrors the fix already applied to release/internal/3.6.x (triton-lang#920).
ethanwee1
added a commit
to ROCm/pytorch
that referenced
this pull request
Jul 23, 2026
…ild-script workaround Point the Triton pin at ROCm/triton#957 (72c9556a1, "Remove git version suffix" on release/internal/3.8.x), which fixes the wheel version at the source. With that commit, TRITON_VERSION no longer appends "+git<sha>", so the build-script workaround in build_triton_wheel.py is unnecessary and is reverted to upstream behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When a consumer (e.g. PyTorch's
build_triton_wheel.py) checks out a pinned commit as a detached HEAD,get_triton_version_suffix()appends a+git<sha>segment. Combined with the externally suppliedTRITON_WHEEL_VERSION_SUFFIX(e.g.+rocm<ver>.git<sha>, whose+is then rewritten to-), the wheel ends up versioned3.8.0+git<sha>.rocm<ver>.git<sha>.That no longer matches the
triton==3.8.0+rocm<ver>.git<sha>dependency that gets pinned into the torch wheel, sopip install torchfails to resolve triton:Fix
Build
TRITON_VERSIONfrom the base version plus only the externally suppliedTRITON_WHEEL_VERSION_SUFFIX, instead of also appending the git commit hash viaget_triton_version_suffix().Mirrors the fix already applied to
release/internal/3.6.x(#920).