[CI] Parity: preserve partial reports on download failure - #3557
Open
ethanwee1 wants to merge 1 commit into
Open
[CI] Parity: preserve partial reports on download failure#3557ethanwee1 wants to merge 1 commit into
ethanwee1 wants to merge 1 commit into
Conversation
… job failed When an upstream config's jobs are missing (e.g. ROCm distributed test job skipped during GPU capacity crunches), download_testlogs exits non-zero and, with `set -o pipefail`, aborted the whole generate-parity job before the CSV was built or uploaded -- so no report at all for that arch. Capture download_testlogs' real exit code instead of aborting, let the report generate and upload from whatever downloaded (default/inductor), then fail the job at the end via a dedicated "Flag incomplete download" step. Net effect for e.g. mi300 with distributed off: the per-arch report + artifact are still produced (and summarize still aggregates via `if: !cancelled()`), but the arch job is clearly marked failed so the incomplete download is visible.
This was referenced Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continue report generation and artifact upload after an incomplete download, then fail the architecture job at the end so partial data remains available without a false green result.
Clean replacement for #3433 on current
develop, stacked on #3554.Test plan
parity.ymlas YAMLMade with Cursor
Alignment landing order
Depends on #3554 and should land after #3558 so missing configs produce a partial artifact before the job is flagged failed.