Skip to content

[CI] Parity: classify newly observed ROCm skips #3523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ethanwee1 wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

[CI] Parity: classify newly observed ROCm skips #3523

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4159f02
[CI] Parity: classify Triton/TVM backend test suites (#9)
ethanwee1 Aug 3, 2026
42d7079
[CI] Parity: classify newly observed ROCm skips
ethanwee1 Aug 4, 2026
e9268f4
[CI] Parity: align remaining ROCm skip classifications
ethanwee1 Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 56 additions & 0 deletions .automation_scripts/pytorch-unit-test-scripts/auto_classify_skip_reasons.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,12 @@
# TIER 1: High-specificity combined rules (message + file/class)
# ==================================================================

# --- PT2.0 - Convolution: conv2d backward parametrized skipped on ROCm ---
# Must precede the generic Misc "test skipped on ('gfx...')" rule.
{"reason": "PT2.0 - Convolution",
"msg": r"test skipped on \('gfx",
"name": r"(?i)conv2d_backward"},

# --- bfloat16_SDPA_ME: dropout mask in test_transformers with bfloat16 in TEST NAME ---
# Must be before generic SDPA_ME rule
{"reason": "bfloat16_SDPA_ME",
Expand Down Expand Up @@ -110,6 +116,30 @@
"file": r"^test_nn$",
"msg": r"skipIfRocm.*doesn't currently work"},

# --- Linalg: hipSOLVER version guards and ROCm linalg regressions ---
{"reason": "Linalg",
"msg": r"hipSOLVER xgeev"},
{"reason": "Linalg",
"msg": r"regression in ROCm 6\.4"},

# --- Profiler: CUPTI-dependent profiler tests ---
{"reason": "Profiler",
"msg": r"(?i)cupti"},

# --- block_table: ROCm does not support paged-KV block_table ---
{"reason": "block_table",
"msg": r"ROCm does not support block_table"},

# --- explicit NVIDIA test: CUDA / SM-gated tests skipped on ROCm ---
{"reason": "explicit NVIDIA test",
"msg": r"only supported on NVIDIA CUDA"},
{"reason": "explicit NVIDIA test",
"msg": r"^CUDA-only$"},
{"reason": "explicit NVIDIA test",
"msg": r"requires CUDA SM80"},
{"reason": "explicit NVIDIA test",
"msg": r"CUTLASS.*CUDA-only"},

# --- hipSolver/Magma: skipCUDAIfRocm in test_ops for ldl_solve, scaled_dot_product, conv_transpose3d ---
{"reason": "hipSolver/Magma",
"msg": r"skipCUDAIfRocm.*doesn't currently work",
Expand All @@ -131,6 +161,8 @@
"msg": r"Skipped for ROCm!"},
{"reason": "hipSolver/Magma",
"msg": r"test_cow_input does not work with efficient attention on ROCM"},
{"reason": "hipSolver/Magma",
"msg": r"hipSOLVER DnXsytrs requires ROCm >= 7\.14"},

# --- Compiler issue: "Skipped!" in test_ops for specific compiler-related tests ---
{"reason": "Compiler issue",
Expand Down Expand Up @@ -429,6 +461,10 @@
{"reason": "Misc",
"msg": r"Test skipped for ROCm"},

# Misc: generic skipIfRocm pointing at a tracked GitHub issue.
{"reason": "Misc",
"msg": r"skipIfRocm: https?://"},

# Misc: architecture-specific skips
{"reason": "Misc",
"msg": r"test skipped on \('gfx"},
Expand Down Expand Up @@ -497,6 +533,26 @@
{"reason": "PT2.0 - Inductor",
"file": r"^inductor\.test_loop_ordering$"},

# --- inductor.test_triton_kernels (Triton HOP / custom-dialect mutation
# analysis tests). AI-analysis flagged these as churning an unrelated
# skip-category when new upstream tests land; they belong to Inductor. ---
{"reason": "PT2.0 - Inductor",
"file": r"^inductor[./]test_triton_kernels$"},

# --- inductor.test_triton_heuristics (skipUnless(HAS_GPU_AND_TRITON)
# guards; GPU/Triton-required inductor tests) ---
{"reason": "PT2.0 - Inductor",
"file": r"^inductor[./]test_triton_heuristics$"},

# --- inductor.test_fused_attention (SDPA pattern-rewriter tests) ---
{"reason": "PT2.0 - Inductor",
"file": r"^inductor[./]test_fused_attention$"},

# --- dynamo.test_backends (TVM and other dynamo backend tests; e.g. TVM
# backend tests enabled/skipped by apache-tvm availability) ---
{"reason": "PT2.0 - Dynamo",
"file": r"^dynamo[./]test_backends$"},

# --- torch_np / numpy tests ---
{"reason": "NumPy",
"file": r"^torch_np\."},
Expand Down