test(activation): skip fp4 silu_and_mul_quant on non-gfx950 archs - #4925
Open
zjin-lcf wants to merge 1 commit into
Open
test(activation): skip fp4 silu_and_mul_quant on non-gfx950 archs#4925zjin-lcf wants to merge 1 commit into
zjin-lcf wants to merge 1 commit into
Conversation
FP4 (e2m1) output relies on CDNA4-only MFMA and is compiled in only for gfx950/gfx1250 (guarded by #if defined(__Float4_e2m1fn_x2) in csrc/kernels/activation_kernels.cu). On gfx942 (MI300A/MI300X) the fp4 branch is compiled out, so the dispatch hits AITER_CHECK(false) and aborts the whole test process. Gate the fp4 case on the runtime gfx (matching the mxfp4 skip idiom in test_moe_ep.py) so it is skipped cleanly, letting the remaining activation tests run. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
PR title tags: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FP4 (e2m1) output relies on CDNA4-only MFMA and is compiled in only for gfx950/gfx1250 (guarded by #if defined(__Float4_e2m1fn_x2) in csrc/kernels/activation_kernels.cu). On gfx942 (MI300A/MI300X) the fp4 branch is compiled out, so the dispatch hits AITER_CHECK(false) and aborts the whole test process. Gate the fp4 case on the runtime gfx (matching the mxfp4 skip idiom in test_moe_ep.py) so it is skipped cleanly, letting the remaining activation tests run.