Skip to content

fix(player-mock): Give PlayerMockService its own type so callers do not need a cast #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Quenty wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(player-mock): Give PlayerMockService its own type so callers do not need a cast #819

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/player-mock/src/Server/PlayerMockService.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,11 @@ local Players = game:GetService("Players")
local PlayerMock = require("PlayerMock")
local PlayerMockServiceBase = require("PlayerMockServiceBase")

local PlayerMockService = setmetatable({}, { __index = PlayerMockServiceBase })
export type PlayerMockService = PlayerMockServiceBase.PlayerMockServiceBase & {
CreatePlayer: (self: PlayerMockService, overrides: { [string]: any }?) -> Player,
}

local PlayerMockService = (setmetatable({}, { __index = PlayerMockServiceBase }) :: any) :: PlayerMockService
PlayerMockService.ServiceName = "PlayerMockService"
PlayerMockService._consumedAttributeName = "PlayerMockConsumedServer"
PlayerMockService._allowConcurrentConsumers = false
Expand All @@ -44,10 +48,7 @@ PlayerMockService._allowConcurrentConsumers = false
@param overrides { [string]: any }? -- Per-property seed values, e.g. `{ UserId = 12345 }` (see [PlayerMock.new]).
@return Player
]=]
function PlayerMockService.CreatePlayer(
self: PlayerMockServiceBase.PlayerMockServiceBase,
overrides: { [string]: any }?
): Player
function PlayerMockService.CreatePlayer(self: PlayerMockService, overrides: { [string]: any }?): Player
local player = PlayerMock.new(overrides)
player.Parent = Players

Expand Down
Loading