E721: report reversed type comparisons#1319
Closed
l46983284-cpu wants to merge 1 commit into
Closed
Conversation
E721 only flagged `type(x) == T` and missed `T == type(x)` because the allow-path inspected only the first regex capture group. Always report when COMPARE_TYPE_REGEX matches so both orders are covered. Fixes PyCQA#1187 Signed-off-by: Alex Chen <l46983284@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
E721 already caught
type(obj) == intbut not the reversed formint == type(obj), becausecomparison_typereturned early when the first capture group (type on the right of==/!=) was a plain identifier.This drops that early return so both comparison orders are reported. Allowed exact checks remain
type(x) is T/is not, and instance checks stayisinstance().Fixes #1187
Test plan
testing/data/E72.pypytest tests/ testing/ -q→ 767 passed, 11 skipped