Docs text pass: every user-facing page to the writing.md standard#1113
Merged
Conversation
Per docs/writing.md: cut the two formerly-called parentheticals and a TODO (production history), fix the Value Type example (url is a Property Type; the Value Type is string), state which Value Types are multi-part (String, Relation) and which are single (Number, Boolean), add the missing Property Type entry and its link to Value Types, tie Statement propertyName to the Subject's Schema, deduplicate the View Type example triplet and the Display Rule prose/bullets, unify examples on infobox/card/table, remove the no-Layout fallback restated from the View section, and reduce Page Property lifecycle mechanism to the Extending pointer. A fresh-context blind judge reviewed the intermediate state; its surviving findings (multi-part ambiguity, Property Type entry, Schema linkage) are applied here. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…etion contracts Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…-safety notes Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…nclusive Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…tement and unregistered-type facts Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
JeroenDeDauw
marked this pull request as ready for review
July 20, 2026 23:12
Member
Author
|
Did a cursory review and did not spot issues |
Resolve the graph-model.md conflict from #1080 (stub Subject nodes). The branch's rewrite claimed a removed-but-referenced node "keeps its Schema labels and dynamic properties"; #1080 changed the code to strip such nodes to id + wiki_id + Subject-label stubs, making that claim false. Take master's Stub-Subject-nodes section and its corrected one-line deletion paragraph; the rest of the branch's rewrite stands. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
alistair3149
pushed a commit
that referenced
this pull request
Jul 21, 2026
The docs-fleet rewrite agent's closing tool-call tags (</content>, </invoke>) ended up as the file's last two lines in #1113. VitePress runs markdown through the Vue template compiler, which rejects the stray end tags, so every website build syncing master docs fails. Two-line deletion; the fleet's other 14 files audited clean for the same token class. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows-up to #1106 and applies docs/writing.md across every user-facing docs page: 15 files, 590 insertions, 1112 deletions, one commit per file so any single page can be reverted alone.
Each page went through a three-stage pipeline: a rewrite agent bound to the page's genre row and required to verify every behavioral claim against source before keeping or tightening it; a fresh-context judge seeing only the artifact and the standard; and a conservative apply step that re-verified the judge's factual findings before touching the file. A review pass followed and restored three over-cuts: the
$wgNamespaceProtectioncaveat and the OpenAPI spec-registration snippet in rest-api.md, and the parameter-injection note in query-api.md.The pass removed false claims, not just noise. Notable corrections:
date/dateTimeas reserved/not implemented; both are registered, working types. Their fields are now documented, as are text's previously undocumentedminLength/maxLength.propertyDefinitionswrapper, so it could not be pasted as-is.{{#view}}'s behavior for a nonexistent Subject ID.GET /subject-labelsis now documented as the exception that does not enforce per-pageread, andexpand=relationsas also dropping targets on unreadable pages.neo-graph:prefix that is deliberately not emitted; the value-type list saiddate-timewhere the type name isdateTime.urla Value Type (it is a Property Type storing a StringValue) and carried a publishedTODO.Per-file ledger: considered-omitted cuts, skipped judge findings, unverified claims
glossary.md (151→135) — omitted: dedicated Validation entry (validation-codes.md is the home); "no stored Default Layout entity" clarification; inline Cypher example. Unverified: none.
api/graph-model.md (128→119) — omitted: overview restating the diagram; ISO-conversion note; constraint-idempotency mechanism; duplicate namespace examples. Skipped: exact stored date serialization (below wire register). Unverified: "Founded at: 2019" rendering (code-consistent, not run live).
api/query-api.md (375→267) — omitted: the ~80-line curl walkthrough (restated the contracts); temporal-rendering paragraph (folded into the table); apihighlimits rationale;
$wgNeoWikiQueryLimitsoverride PHP example (key remains documented); SPARQL "differences from Cypher" bullets. Unverified: duration/point JSON shapes fall through to the Laudis driver.api/rest-api.md (177→~173) — omitted: DOC-INTENT editorial comment (superseded by writing.md); "render without follow-up" narration. Skipped: write auth/CSRF mechanics (standard MediaWiki); pagination signaling (deferred to OpenAPI). Unverified: demo-wiki spec URL liveness.
api/schema-format.md (316→234) — omitted: reserved-types roadmap list (email/phone/…: absent from code, no wire contract); boolean frontend-display note; endpoint re-listing (rest-api.md owns it); trivial one-line examples. Unverified:
precisionis display-only (not enforced in PHP); select id→label display resolution not inspected.api/subject-format.md (297→215) — omitted: Overview section (folded); per-type value examples the new shape table covers; facts homed in validation-codes/graph-model/rest-api. Unverified: none.
authoring/lua-api.md (409→405) — omitted: "use this when" preambles; conversion-table restatement. Skipped: exact accepted Lua parameter types for nw.query (could not cheaply verify; no unverified contract asserted). Unverified: integer-comparison toInteger advice kept as defensive guidance.
authoring/parser-functions.md (205→194) — omitted: Related-Documentation footer; header-restating notes; unregistered-type edge case. Skipped: propertyName case-sensitivity (unverified match semantics); relation "label" definition (glossary's job). Unverified: client-side rendering behaviors (frontend half inferred).
examples/person-to-edm.md (250→215) — omitted: origin/meta framing of the toy model; standalone "findings" section (each folded into its home section); forward-looking seam notes. Unverified: instance-specific literals (page ids, timestamps — flagged in-doc); external CIDOC-CRM path is illustrative.
extending/extending.md (472→451) — omitted: 21-line RDF value-mapper listing identical to the linked RedHerbHooks.php (contract kept in prose). Skipped: one judge finding whose premise was false in code (the adjacent real inaccuracy was fixed instead). Unverified: four pre-existing behavioral claims not traced (SVG icon type, rebuild delete loop, failure paths, no-mapper omission).
operations/installation.md (274→267) — omitted: heading-restating intro; reassurance sentences; SPARQL "no validator needed" mechanism. Skipped: third-party Neo4j provisioning steps (explicitly delegated). Unverified: "Neo4j 5.x" minimum is pinned nowhere in-repo (left as stated).
operations/maintenance.md (70→63) — omitted: stale intro enumeration; outage/rebuild duplication; "lives only in Neo4j, so" mechanism. Skipped: a wipe-the-data-volume command (deployment-specific); naming a changelog source (none verified to exist).
qualifiers-and-references.md (143→100) — omitted: "The short version" duplicate walkthrough; "Why this approach" advocacy section (two content-bearing points moved to the intro); dev-state issue links; RDF reification mechanism (round-trip contract kept). Skipped: a novalue/somevalue modeling recipe (would be speculative). Unverified: RDF round-trip losslessness for the qualified-value pattern.
rdf/ontology-mapping.md (171→137) — omitted: projection-selection curl/DumpRdf duplication (rdf-export.md owns it); rationale clauses; raw issue link. Skipped: two judge findings whose premises were wrong (named graphs share a store); reserved-prefix trap (could not prove, would risk asserting falsehood).
rdf/rdf-export.md (160→149) — omitted: IRI-encoding security justification; autodiscovery rationale; "later concerns" intro. Skipped: authentication (MediaWiki-level, not this page's home); full emitted-predicate enumeration (NativeRdfProjection.md's home). Unverified: illustrative example IRIs.