Add egMapsLeafletLayerDefinitions setting for custom Leaflet layers#921
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Review follow-ups: prototype-safe layerDefinitions lookup in the client, a docs note that definitions override same-named stock layers and that attribution is rendered as HTML, and a test pinning the shadowing serialization. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
JeroenDeDauw
marked this pull request as ready for review
July 18, 2026 21:50
array_merge renumbers integer-like array keys, so a custom Leaflet layer whose name is purely numeric (e.g. "1904") was silently dropped from the available-layers whitelist and never rendered. Use the union operator instead, which preserves such keys while keeping custom names taking precedence over a same-named stock layer. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
$egMapsLeafletLayerDefinitionssetting for custom named Leaflet tile and WMS layers. Eachdefinition's name becomes a valid value of the
layersandoverlaysparameters — in#display_map/format=leafletmaps and query result formats alike. Only the definitions a map actually uses areserialized to the client.