auth api: flush all caches when flushing

[zeha]

Short description

So far we never flushed the DNSSEC caches, except when DELETEing a domain. However clearly some operations can affect the DNSSEC settings, and then the caches should go.

Also do this for the flush API, to be consistent, and for users writing to the DNSSEC settings/data externally.

Checklist

I have:

• read the CONTRIBUTING.md document
• compiled this code
• tested this code
• included documentation (including possible behaviour changes)
• documented the code
• added or modified regression test(s)
• added or modified unit test(s)

[coveralls]

Pull Request Test Coverage Report for Build 7226248045

• 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
• 31 unchanged lines in 6 files lost coverage.
• Overall coverage increased (+0.3%) to 57.993%

---

Files with Coverage Reduction	New Missed Lines	%
pdns/pollmplexer.cc	1	82.61%
modules/godbcbackend/sodbc.cc	2	70.8%
pdns/misc.cc	2	63.04%
pdns/signingpipe.cc	5	83.33%
pdns/packethandler.cc	8	73.07%
pdns/recursordist/test-syncres_cc1.cc	13	88.75%

Totals
Change from base Build 7222412548:	0.3%
Covered Lines:	108173
Relevant Lines:	155130

---

💛 - Coveralls

[klaus-nicat]

Does this also clear the domainmetadata-cache?

[zeha]

It should. Maybe having a test for it would be nice, but I'm not sure how to go about that.

[zeha]

Rebased this in the hope of getting an all green CI.

[zeha]

  FAILED test_Lua.py::LuaHooksRecursorTest::testPreResolve - TypeError: msg is not a dns.message.Message but a <class 'NoneType'>
  FAILED test_Lua.py::LuaHooksRecursorTest::testVanillaNXD - ConnectionRefusedError: [Errno 111] Connection refused
  FAILED test_Lua.py::LuaHooksRecursorDistributesTest::testPreResolve - TypeError: msg is not a dns.message.Message but a <class 'NoneType'>
  FAILED test_Lua.py::LuaHooksRecursorDistributesTest::testVanillaNXD - ConnectionRefusedError: [Errno 111] Connection refused

these don't seem to be introduced by my PR?

[rgacogne]

  FAILED test_Lua.py::LuaHooksRecursorTest::testPreResolve - TypeError: msg is not a dns.message.Message but a <class 'NoneType'>
  FAILED test_Lua.py::LuaHooksRecursorTest::testVanillaNXD - ConnectionRefusedError: [Errno 111] Connection refused
  FAILED test_Lua.py::LuaHooksRecursorDistributesTest::testPreResolve - TypeError: msg is not a dns.message.Message but a <class 'NoneType'>
  FAILED test_Lua.py::LuaHooksRecursorDistributesTest::testVanillaNXD - ConnectionRefusedError: [Errno 111] Connection refused

these don't seem to be introduced by my PR?

Looks like #13587 so a rebase should help.

[zeha]

rebases for everyone! err, for this branch!

[rgacogne]

FAILED test_SimpleForwardOverDoT.py::testSimpleForwardOverDoT::testA - AssertionError: False is not true : No AD flag found in the message for dns.google.

This one is indeed flaky, restarted.

[zeha]

This one is indeed flaky, restarted.

green \o/

[zeha]

I fixed the rebase and this has also resulted in #13641