fix(batch-imports): decode all members of concatenated gzip files - #90036
Open
pl wants to merge 3 commits into
Open
fix(batch-imports): decode all members of concatenated gzip files#90036pl wants to merge 3 commits into
pl wants to merge 3 commits into
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Contributor
🤖 CI report✅ Trunk lane — non-backend laneThis PR is assigned to the non-backend lane. It does not run backend Python tests and may merge in parallel with PRs in other lanes. |
pl
marked this pull request as ready for review
August 27, 2026 12:40
Contributor
|
Reviews (1): Last reviewed commit: "chore(batch-imports): extend gzip extrac..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
GzDecoderstops at the first member's end, which is indistinguishable from the end of the file, so the extractor records a one-event part as complete.Changes
MultiGzDecoderreplacesGzDecoderin both producers (s3_gzipfiles, and gzip inside Amplitude zip entries); single-member streams decode identically.Note
Two loud-failure behavior changes, both replacing silent truncation:
Warning
Rollout notes:
How did you test this code?
test_plain_gzip_extractor_concatenated_members: three per-record members; fails under a single-member decoder, which stops after the first record with a clean EOF.test_zip_gzip_json_extractor_concatenated_members_in_entry: the same regression on the zip path; the two decoder call sites are independent.test_plain_gzip_extractor_trailing_garbage_errors: pins that trailing non-gzip bytes surface an error rather than a clean EOF.dump_record_batchwith gzip: 3 records produced 3 gzip members, and a single-member decode returned only the first record with 110 bytes unread.Automatic notifications
Docs update
None in this repo.
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
hogli reviewcould not run on this machine (Greptile CLI install fails with npm EPERM; reported via devex feedback), so the local pass was the harness fallback review. The independent review is the PR bot's.total_sizerevalidation (possible follow-up in job resume logic). Rejected: folding the multi-member case into the newline-normalization table, because the fixture shape differs (that table's builder is single-member).