trunk-merge/pr-88862/8b8f0f30-3d2b-4b39-8031-47a86da79e45 - #89647
Closed
trunk-io[bot] wants to merge 304 commits into
Closed
trunk-merge/pr-88862/8b8f0f30-3d2b-4b39-8031-47a86da79e45#89647trunk-io[bot] wants to merge 304 commits into
trunk-io[bot] wants to merge 304 commits into
Conversation
A date-typed incremental key, such as one built with toStartOfWeek or toStartOfMonth, stores a Date watermark. window_start shifted the watermark back by lookback_seconds only for datetime watermarks, so the lookback was silently ignored for date keys. Late-corrected rows were never re-scanned and the materialized view drifted with no error. Shift date watermarks too, by whole days, rounding the lookback down. Generated-By: PostHog Desktop Task-Id: be5f0d24-dab0-4ad7-87f9-0928e7b78324
A date-typed incremental key floored the lookback to whole days, so any lookback below one day became zero days. The injected filter is inclusive, so the run then re-scanned only the newest bucket, which happens on every run anyway. The nonzero lookback was a silent no-op and corrections in earlier buckets were never rebuilt. Round the day count up instead: any nonzero lookback now pulls the bound back at least one whole day, so a sub-day lookback re-scans the previous bucket. Whole-day lookbacks are unchanged, and datetime and non-temporal keys are untouched. This follows the module's own preference to re-read rather than silently drop data. Generated-By: PostHog Desktop Task-Id: 50af5614-4d50-41a1-b16b-338c1a458130
Generated-By: PostHog Desktop Task-Id: f1ac2634-4ae4-4683-92b3-54e332b641bc
bin/npm resolves through Cellar to lib/node_modules/npm/bin/npm-cli.js, and Seatbelt matches resolved paths, so the bin/Cellar denies alone left the executed file writable. Generated-By: PostHog Desktop Task-Id: ab2f1c37-3023-4f06-ab9d-d5ba99ac5b16
Generated-By: PostHog Desktop Task-Id: f1ac2634-4ae4-4683-92b3-54e332b641bc
Generated-By: PostHog Desktop Task-Id: 580d939b-cb70-4265-8a89-151add2570a6
Generated-By: PostHog Desktop Task-Id: 9e64274c-da99-4157-a0d9-336898627012
Generated-By: PostHog Desktop Task-Id: 9e64274c-da99-4157-a0d9-336898627012
Generated-By: PostHog Desktop Task-Id: 9e64274c-da99-4157-a0d9-336898627012
Generated-By: PostHog Desktop Task-Id: 9e64274c-da99-4157-a0d9-336898627012
Generated-By: PostHog Desktop Task-Id: 9e64274c-da99-4157-a0d9-336898627012
Generated-By: PostHog Desktop Task-Id: 9e64274c-da99-4157-a0d9-336898627012
`$mcp_tool_call` recorded that a skill was read but never which one, so per-skill usage was unanswerable and the skills product fell back on publish-recency and version churn as a proxy. Stamps `$mcp_skill_name` on `skill-get` and `skill-file-get` (and their `llma-skill-*` aliases), plus `$mcp_skill_body_offset` on the paginated body read so a paged continuation is not counted as a fresh load. Scoped to reads: writes already emit `llma skill *` from the skills API, and stamping them here would give two sources that disagree. Names are recorded only when they match the shape the store enforces at creation, following the value-free rule `execCommandAnalyticsProperties` already states, so agent-supplied text is dropped rather than echoed. Covers both dispatch modes. Single-exec carries arguments as JSON inside the command string, so `parseExecCallInnerArgs` reads them with the dispatcher's own parsers. Generated-By: PostHog Desktop Task-Id: 7a1545c3-8fc2-49bf-bf78-d2cfa6908a35
Generated-By: PostHog Desktop Task-Id: 9e64274c-da99-4157-a0d9-336898627012
Generated-By: PostHog Desktop Task-Id: 9e64274c-da99-4157-a0d9-336898627012
Opening /metrics showed a single centred spinner on an otherwise blank page until both rollup queries came back, so the wait read as a stall with no hint of what was coming. The status strip, the three stat cards, and the services table now render as placeholders sized to the real thing, so the page has its shape immediately and nothing moves when the numbers arrive. `OverviewStat` renders both states, and the card labels and column headers come from one list, so the loading layout cannot drift from the loaded one. Generated-By: PostHog Desktop Task-Id: 32c760da-5be2-4ce4-b74e-56309aa1a594
Generated-By: PostHog Desktop Task-Id: ab2f1c37-3023-4f06-ab9d-d5ba99ac5b16
Every django shard in ci-backend.yml pays roughly 10 s of pytest collection building hypothesis's constants pool: hypothesis AST-parses every local module in sys.modules and caches the result under .hypothesis/constants, keyed by a hash of each source file. That directory is gitignored and was never cached, so each shard rebuilt the pool on every run. Restore the constants directory in every django shard and save it from one master Core shard per run. The key includes the installed hypothesis version and rotates weekly, and a prefix restore-key carries PRs until the first master save of a new week. Entries are content-addressed, so a stale restore is only ever a miss for changed sources, never stale data. Only .hypothesis/constants is cached: the example database under .hypothesis/examples picks which inputs property tests replay and must not travel across runs. The .depot shadow of ci-backend.yml mirrors both steps and notes the one delta: its master runs skip the test matrices, so its save stays dormant until a master dispatch. Measured on the Core collect targets ci-backend uses: cold 31.9 s vs warm 22.4 s collect-only over 31,707 tests. Created with Autoresearch. Generated-By: PostHog Desktop Task-Id: 4f0a3130-0f08-4a15-b57e-15be4e71bca8
The button summarized recordings by counting them per variant and letting the LLM reason over metadata. It never watched a recording. The player now offers an inline Replay vision scan, which does. Removes the button, its Max tool, and the never-created feature flag branch that gated a second unreachable code path. Generated-By: PostHog Desktop Task-Id: 2125706e-58c5-4d31-8c6a-db5015f40291
Removing the session replay tool left the experiment summary flag as the only thing that varies this toolkit, and neither branch was asserted. Generated-By: PostHog Desktop Task-Id: 2125706e-58c5-4d31-8c6a-db5015f40291
trunk-io
Bot
deleted the
trunk-merge/pr-88862/8b8f0f30-3d2b-4b39-8031-47a86da79e45
branch
August 26, 2026 19:06
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was created and is being managed by Trunk Merge.
This pull request is based on the master branch at SHA c86295e66bcb7a647de548d8ff2765f62a5f1dd0.
See more details here.
When CI completes, this pull request will be closed automatically.
Pull Requests Being Tested
This pull request is testing the changes from pull request 88862.
Dependencies
This pull request depends on the changes from pull requests 88886 and 89624.