fix(aio): validate skill reference links resolve in the built bundle - #89629
Draft
posthog[bot] wants to merge 1 commit into
Draft
fix(aio): validate skill reference links resolve in the built bundle#89629posthog[bot] wants to merge 1 commit into
posthog[bot] wants to merge 1 commit into
Conversation
The skill build strips the .j2 suffix from every rendered template, so a SKILL.md that links to a `.md.j2` reference points at a path the bundle never contains. Add a blocking lint check that resolves every references/ and scripts/ link in each SKILL.md against the shipped bundle, and fix the one skill that linked a template path. Generated-By: PostHog Desktop Task-Id: 51745b3a-bba0-431b-8b69-fc0e4170d7c2
Contributor
Author
🦔 ReviewHog reviewed this pull requestNothing worth raising this time, so here's a calming picture instead:
|
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Contributor
🤖 CI report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
.j2suffix when it renders a template. ASKILL.mdlink to a.md.j2path then points at a file the bundle does not contain.exploring-llm-traceslinkedreferences/example-llm-trace.md.j2, but the bundle holds only the renderedreferences/example-llm-trace.md.Note
The inbox report named
creating-online-evaluations→references/evaluation-payload.md. That link is correct: the source holdsevaluation-payload.md.j2, which the build renders toevaluation-payload.md, so the bundled link resolves. The real break is the reverse case inexploring-llm-traces, which the new check now catches.Changes
SKILL.mdlinks areferences/orscripts/path that the built bundle will not contain.exploring-llm-tracesnow links the renderedreferences/example-llm-trace.md, so the reference opens..mdlink when the source holds either the.mdfile or its.md.j2template. It scans only theSKILL.mdentry point.How did you test this code?
test_build_skills.py: aSKILL.mdlinking a.md.j2template fails the lint; aSKILL.mdlinking the rendered.mdof a template passes. These catch a reintroduced template-path link, which no existing test covered.Automatic notifications
Docs update
None.
🤖 Agent context
Autonomy: Fully autonomous
/writing-tests,/writing-pr-descriptions,/writing-simplified-technical-english..md.j2or adding a static.md. Both are wrong here: repointing to.md.j2breaks the bundle, and a static.mdwould drift from the Pydantic-rendered template. The durable fix is the publication check the report also suggested, which confirmed the named skill is fine and surfaced the genuine break in a sibling skill.Created with PostHog Desktop from this inbox report.