fix(access-control): show objects shared with everyone in the project in lists - #89627
Draft
a-lider wants to merge 1 commit into
Draft
fix(access-control): show objects shared with everyone in the project in lists#89627a-lider wants to merge 1 commit into
a-lider wants to merge 1 commit into
Conversation
Contributor
🤖 CI report
|
… in lists
An object's default ("everyone in the project") grant now puts it on the
list allowlist, matching what the detail endpoint already serves. Explicit
member and role rows still decide first, so a personal "none" keeps hiding
the object.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YLPsrMcxEG1NZL4AzS1LXh
a-lider
force-pushed
the
alex/fix/default-grant-allowlist
branch
from
August 26, 2026 18:39
2240b35 to
608f241
Compare
a-lider
changed the base branch from
alex/refactor/unify-object-row-decision
to
master
August 26, 2026 18:40
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A user with resource-level "No access" loses objects from lists that they can still open by URL. Example: dashboards are "No access" for the user, one dashboard is shared as "Everyone in the project: editor". The dashboard opens from a direct link, but the dashboards list does not show it.
The list allowlist only counted member and role grants. A default ("everyone in the project") grant on the object never counted, so the list and the detail endpoint disagreed.
Changes
_blocked_and_allowed_object_idsnow adds an object to the allowed set when its default rows grant a level above "none". Two lines plus docstrings.allowlisted_resource_ids_by_scopeinherits the change, so the HogQL guard, the schema gate, andee/api/subscription.pywiden the same way. The change is additive only: nothing newly readable, since the detail endpoint already served these objects.Independent of the refactor in #89361; whichever lands second rebases a small conflict in the same method.
How did you test this code?
test_filter_queryset_allowlists_objects_granted_to_everyone: catches the regression where an everyone-share disappears from lists under resource-level "none", and asserts a member "none" row still overrides the grant. No existing test covered the default-grant shape.oracle_blocked_and_allowed_object_ids) to the new rule; the PBT suite holds the implementation, the HogQL guard derivation, and REST filtering to that oracle across arbitrary row configurations.Automatic notifications
Docs update
None —
posthog/hogql/ACCESS_CONTROL.mddoes not state the old allowlist rule.🤖 Agent context
Autonomy: Human-driven (agent-assisted)