docs: add the rokt ads source page - #19824
Open
jakesciotto wants to merge 3 commits into
Open
Conversation
The Rokt Ads warehouse source sets docsUrl to /docs/cdp/sources/rokt-ads, which had no page behind it, so the link from the connect wizard returned a 404. Adds the page, following the structure of the other advertising source pages. Generated-By: PostHog Desktop Task-Id: d8766944-e16c-41ae-b2e9-8eccfb718a96
Contributor
Deploy preview
|
Vale reported 15 warnings on the new page. Fourteen were the vendor name. Rokt is a brand, so it goes in the BrandsAndTechnologies vocabulary next to the other vendor names. The last one was real: ProductNames asks for "Data Warehouse" when the phrase names PostHog's product rather than the industry concept, and this sentence names the product. Generated-By: PostHog Desktop Task-Id: d8766944-e16c-41ae-b2e9-8eccfb718a96
Contributor
Bundle reportTotal JS (gzip)8.15 MiB (no change) Eager graph (modules shipped in each entrypoint's initial chunks)
Largest modules in the
|
| Module | Size |
|---|---|
./src/data/mcp-tools.json |
1053.9 KiB |
css ./node_modules/.pnpm/css-loader@5.2.7_webpack@5.101.3/node_modules/css-loader/dist/cjs.js??ruleSet[1].rules[8].oneOf[1].use[1]!./node_modules/.pnpm/postcss-loader@4.3.0_postcss@8.5.6_webpack@5.101.3/node_modules/postcss-loader/dist/cjs.js??ruleSet[1].rules[8].oneOf[1].use[2]!./src/styles/global.css |
754.5 KiB |
./src/components/Stickers/Stickers.tsx |
696.4 KiB |
./node_modules/.pnpm/@radix-ui+react-icons@1.3.2_react@18.3.1/node_modules/@radix-ui/react-icons/dist/react-icons.esm.js |
481.4 KiB |
./node_modules/.pnpm/rehype-raw@7.0.0/node_modules/rehype-raw/lib/index.js + 29 modules |
395.1 KiB |
./src/hooks/useCustomers.tsx + 55 modules |
370.0 KiB |
./node_modules/.pnpm/@posthog+icons@0.36.6_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/@posthog/icons/dist/posthog-icons.es.js |
354.8 KiB |
./node_modules/.pnpm/react-markdown@8.0.7_@types+react@16.14.66_react@18.3.1/node_modules/react-markdown/lib/react-markdown.js + 88 modules |
351.4 KiB |
./src/components/ProductComparisonTable/index.tsx + 126 modules |
301.7 KiB |
./node_modules/.pnpm/cloudinary-core@2.14.0_lodash@4.17.21/node_modules/cloudinary-core/cloudinary-core.js |
281.9 KiB |
./src/components/SearchUI/index.tsx + 87 modules |
273.0 KiB |
./node_modules/.pnpm/@posthog+brand@0.8.0_react@18.3.1/node_modules/@posthog/brand/dist/generated/hoggies/svg/magnifying-glass.mjs |
254.7 KiB |
./node_modules/.pnpm/framer-motion@10.18.0_react-dom@18.3.1_react@18.3.1__react@18.3.1/node_modules/framer-motion/dist/es/render/dom/motion.mjs + 109 modules |
253.9 KiB |
./node_modules/.pnpm/d3@7.9.0/node_modules/d3/src/index.js + 208 modules |
247.4 KiB |
./src/components/Pricing/PricingSlider/Slider.tsx + 87 modules |
240.1 KiB |
Eager-graph budgets are report-only until a baseline is established. Sizes are gzip of public/**/*.js; eager size is webpack module source bytes for the modules actually shipped in the entrypoint's initial chunks (post-tree-shake).
Rendering the page against the deployed source showed the generated table reporting "Incremental, Full refresh" for the five report tables, while the hand-written table above it named incremental only. The five report tables offer both methods, so the table now says so, and the note underneath says why incremental is the better choice. Generated-By: PostHog Desktop Task-Id: d8766944-e16c-41ae-b2e9-8eccfb718a96
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Executive summary
The Rokt Ads warehouse source shipped in PostHog/posthog#82608. Its source config sets
docsUrlto/docs/cdp/sources/rokt-ads, but no page existed at that path, so the "Read the docs" link in the connect wizard returned a 404. This adds the page.The page follows the structure of the other advertising source pages, such as Amazon Ads: what the connector pulls, how to connect it, which tables it offers, then the
<SourceParameters />and<SourceTables />blocks.Two parts of the page describe behavior a person will otherwise be surprised by:
The alpha callout matches
releaseStatus=ReleaseStatus.ALPHAon the source config, so the page states the status the product already ships.Before you open a PR
pnpm formatglobs{html,js,ts,tsx,json,yml,css,scss}and does not cover.md, so it is a no-op for this diff.node_modulesis absent in my environment. Instead I checked the page on the Cloudflare deploy preview this PR builds, which renders the real page.The preview confirms the page renders correctly:
Configurationrenders the five fields from the source config: App ID, App secret, and Account ID as required, with Time zone and Currency code optional.Supported tablesrenders all six tables with their descriptions, sync methods, and incremental fields.Rendering it found one error that reading the file did not. The generated table reports "Incremental, Full refresh" for the five report tables, but the hand-written table above it named incremental only. That is fixed, and the note underneath now says why incremental is the better choice.
An earlier preview showed an empty
Configurationheading, because the source had not deployed yet and the build reads source metadata from/api/public_source_configs. The source is now live, so the section fills in. No navigation change, because source pages are not listed insrc/navs/index.js. No page moved or was renamed, sovercel.jsonneeds no redirect.Vale
The first run reported 15 warnings. Both causes are fixed in this PR, which is why it also touches one file outside
contents/:'Rokt' is a possible misspelling. Rokt is a brand name, so it now sits in theBrandsAndTechnologiesvocabulary alongside HubSpot, Klaviyo, and the other vendors. Without this, every future page that names Rokt repeats the same 14 warnings.ProductNamesasks for "Data Warehouse" when the phrase names PostHog's product rather than the general industry concept, and that sentence names the product.Worth flagging for the reviewer: the lowercase form appears in about 106 pages under
contents/docs/against roughly 12 capitalized, so the corpus has drifted from the rule the linter encodes. I followed the linter here rather than the neighboring pages. Say the word if you would rather match the neighbors, and I will revert that one word.Notes
The source logo is a separate PR on the main repo, PostHog/posthog#91320. This page reads
icon_urlfrom the same source config, so that PR also supplies the icon shown here.