Fix flaky date tests comparing two separate time() calls#60
Merged
Conversation
slayerfx
force-pushed
the
fix/flaky-date-tests
branch
from
July 20, 2026 13:49
d654827 to
1e14ad4
Compare
Progi1984
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The argument-less date setters call
time()internally, while the tests captured their owntime()beforehand and compared both withassertEqualsfailing whenever the second changed between the two calls (turned the CI red on #56). The date is now asserted against a[before, after]range instead.TaskTest,DocumentInformationsTest,DocumentPropertiesTest(6 tests)