php8 compatibility#842
Merged
Merged
Conversation
OskarStark
approved these changes
Nov 27, 2020
Owner
|
Thank you very much 🥰 |
Collaborator
Author
|
Unfortunately, we need to wait for stable 8.0 docker images. |
Owner
|
Any significant performance increase using php 8? |
Owner
|
Images are available, right? |
Collaborator
Author
|
Sure, but not for x86-64 (only arm, ppc and s390) 🙈 |
Collaborator
Author
|
amd64 architecture is now available but box seems to have a problem. Might be related to box-project/box#489 Or box is not ready for PHP 8 but I'm already working on it humbug/php-scoper#446 (first php-scoper needs be php 8 compatible then box can be updated). |
Owner
|
Any news on this @smoench ? |
Collaborator
Author
|
Still in progress box-project/box#508 |
smoench
force-pushed
the
php8
branch
3 times, most recently
from
December 21, 2020 08:10
8a3a294 to
18a1e21
Compare
Owner
|
Looks like its passing, right? |
smoench
marked this pull request as ready for review
December 21, 2020 08:51
Collaborator
Author
|
Yes, it passes now. Just had adjust the |
OskarStark
approved these changes
Dec 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.