Skip to content

php8 compatibility#842

Merged
OskarStark merged 1 commit into
OskarStark:masterfrom
smoench:php8
Dec 21, 2020
Merged

php8 compatibility#842
OskarStark merged 1 commit into
OskarStark:masterfrom
smoench:php8

Conversation

@smoench

@smoench smoench commented Nov 27, 2020

Copy link
Copy Markdown
Collaborator

No description provided.

@OskarStark

Copy link
Copy Markdown
Owner

Thank you very much 🥰

@smoench

smoench commented Nov 27, 2020

Copy link
Copy Markdown
Collaborator Author

Unfortunately, we need to wait for stable 8.0 docker images.

@OskarStark

Copy link
Copy Markdown
Owner

Any significant performance increase using php 8?

@OskarStark

Copy link
Copy Markdown
Owner

Images are available, right?

@smoench

smoench commented Dec 1, 2020

Copy link
Copy Markdown
Collaborator Author

Sure, but not for x86-64 (only arm, ppc and s390) 🙈

@smoench

smoench commented Dec 2, 2020

Copy link
Copy Markdown
Collaborator Author

amd64 architecture is now available but box seems to have a problem. Might be related to box-project/box#489

 ---> 1d6fb4c0c879
Step 7/19 : ADD https://github.com/humbug/box/releases/download/3.10.0/box.phar ./box.phar
Downloading [==================================================>]   1.89MB/1.89MB
 ---> 30a4fd1945dc
Step 8/19 : RUN php box.phar compile
 ---> Running in f81d5263f939

Box Requirements Checker
========================

> Using PHP 8.0.0
> PHP is using the following php.ini file:
  WARNING: No configuration file (php.ini) used by PHP!

> Checking Box requirements:
  E.....


 [ERROR] Your system is not ready to run the application.


Fix the following mandatory requirements:
=========================================

 * The application requires the version "^7.3" or greater.

The command '/bin/sh -c php box.phar compile' returned a non-zero code: 1

Or box is not ready for PHP 8 but I'm already working on it humbug/php-scoper#446 (first php-scoper needs be php 8 compatible then box can be updated).

@OskarStark

Copy link
Copy Markdown
Owner

Any news on this @smoench ?

@smoench

smoench commented Dec 14, 2020

Copy link
Copy Markdown
Collaborator Author

Still in progress box-project/box#508

@smoench
smoench force-pushed the php8 branch 3 times, most recently from 8a3a294 to 18a1e21 Compare December 21, 2020 08:10
@OskarStark

Copy link
Copy Markdown
Owner

Looks like its passing, right?

@smoench
smoench marked this pull request as ready for review December 21, 2020 08:51
@smoench

smoench commented Dec 21, 2020

Copy link
Copy Markdown
Collaborator Author

Yes, it passes now. Just had adjust the Dockerfile

@OskarStark
OskarStark merged commit c34cdea into OskarStark:master Dec 21, 2020
@smoench
smoench deleted the php8 branch December 21, 2020 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants