Skip to content

scheduler: Fix typo in have_source check preventing default trays #1649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hissamshar wants to merge 2 commits into
base: master
Choose a base branch
from
Open

scheduler: Fix typo in have_source check preventing default trays #1649

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b142000
scheduler: Fix typo in have_source check preventing default trays
hissamshar Jul 11, 2026
ed01ca1
Fix syntax error: !== is not valid C, use !
hissamshar Jul 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scheduler/job.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3787,7 +3787,7 @@ get_options(cupsd_job_t *job, /* I - Job */
}

have_size = ippFindAttribute(job->attrs, "PageRegion", IPP_TAG_ZERO) != NULL || ippFindAttribute(job->attrs, "PageSize", IPP_TAG_ZERO) != NULL;
have_source = ippFindAttribute(job->attrs, "InputSlot", IPP_TAG_ZERO) != NULL || ippFindAttribute(job->attrs, "HPPaperSource", IPP_TAG_ZERO) == NULL;
have_source = ippFindAttribute(job->attrs, "InputSlot", IPP_TAG_ZERO) != NULL || ippFindAttribute(job->attrs, "HPPaperSource", IPP_TAG_ZERO) !== NULL;
Comment thread
hissamshar marked this conversation as resolved.
Outdated
have_type = ippFindAttribute(job->attrs, "MediaType", IPP_TAG_ZERO) != NULL;

if (banner_page && (attr = ippFindAttribute(job->attrs, "job-sheets-col", IPP_TAG_BEGIN_COLLECTION)) != NULL)
Expand Down